From ce04dc5edc28423ea4cb3a63b13aa40a912e1b8f Mon Sep 17 00:00:00 2001 From: emilylange Date: Mon, 3 Feb 2025 02:01:05 +0100 Subject: [PATCH] electron_32: fix log spam when building on aarch64-linux clang-19 deprecation warnings on aarch64-linux specifically are causing the log grow beyond h.n.o's log limit of 64mb, which in turn causes the build to get killed. To work around this, likely until electron_32 is EOL in a month, we simply disable those deprecation warnings. We still have another things causing unnecessary logs, but this should be good enough for now. https://hydra.nixos.org/build/283952243 --- pkgs/development/tools/electron/common.nix | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/pkgs/development/tools/electron/common.nix b/pkgs/development/tools/electron/common.nix index e6306e8d98da..06f50a74c5d0 100644 --- a/pkgs/development/tools/electron/common.nix +++ b/pkgs/development/tools/electron/common.nix @@ -159,6 +159,20 @@ in '' + base.postPatch; + env = + base.env + // lib.optionalAttrs (lib.versionOlder info.version "33" && stdenv.hostPlatform.isAarch64) { + # Hydra fails to build electron_32.aarch64-linux as of 2025-01-05 due to + # clang spamming deprecation warnings mid-build, causing the build log to + # grow beyond the limit of 64mb and then getting killed by Hydra. This + # renders our clang both too old for the latest chromium without the use + # of -Wno-unknown-warning-option and also too new for electron_32 (M128). + # For some reason, this is exclusively happening on aarch64-linux. To + # unbreak the build on h.n.o, we simply disable those warnings for now. + # https://hydra.nixos.org/build/283952243 + NIX_CFLAGS_COMPILE = base.env.NIX_CFLAGS_COMPILE + " -Wno-deprecated"; + }; + preConfigure = '' (