From e43a84b67478fd9a4e7c96a6dc8fdcaeaa8f0301 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Fri, 24 Oct 2025 15:11:41 +0200 Subject: [PATCH] workflows/eval: fix eval report with formatting changes The Eval report which tests performance between Nix/Lix versions on update of `ci/pinned` wrongly returned errors, when only the special attribute `release-checks` changed. Since this reads in all of Nixpkgs, it will change with any formatting change that is introduced at the same time via update of any of `treefmt`'s formatters. --- .github/workflows/eval.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/eval.yml b/.github/workflows/eval.yml index 8ad860a1aed8..dee31e1f5328 100644 --- a/.github/workflows/eval.yml +++ b/.github/workflows/eval.yml @@ -279,12 +279,11 @@ jobs: const diff = JSON.parse( readFileSync(path.join(artifact, system, 'diff.json'), 'utf-8'), ) - const attrs = [].concat( - diff.added, - diff.removed, - diff.changed, - diff.rebuilds - ) + const attrs = [] + .concat(diff.added, diff.removed, diff.changed, diff.rebuilds) + // There are some special attributes, which are ignored for rebuilds. + // These only have a single path component, because they lack the `.` suffix. + .filter((attr) => attr.split('.').length > 1) if (attrs.length > 0) { core.setFailed( `${version} on ${system} has changed outpaths!\nNote: Please make sure to update ci/pinned.json separately from changes to other packages.`,