From 715d372a0c894b4bd2dbb8a45c5ed0eb4590a028 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Mon, 21 Jul 2025 18:08:06 +0200 Subject: [PATCH] hplipWithPlugin: remove assert This assert is already handled by `meta.platforms`, which can be better caught by CI than an `assert`. Also set `meta.platforms` to the earlier defined `hplipPlatforms` for a single source of truth. --- pkgs/by-name/hp/hplip/package.nix | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/pkgs/by-name/hp/hplip/package.nix b/pkgs/by-name/hp/hplip/package.nix index 286ba7d49f04..65133270291f 100644 --- a/pkgs/by-name/hp/hplip/package.nix +++ b/pkgs/by-name/hp/hplip/package.nix @@ -72,12 +72,6 @@ let in -assert - withPlugin - -> - builtins.elem hplipArch pluginArches - || throw "HPLIP plugin not supported on ${stdenv.hostPlatform.system}"; - python3Packages.buildPythonApplication { inherit pname version; format = "other"; @@ -362,13 +356,7 @@ python3Packages.buildPythonApplication { bsd2 gpl2Plus ]; - platforms = [ - "i686-linux" - "x86_64-linux" - "armv6l-linux" - "armv7l-linux" - "aarch64-linux" - ]; + platforms = lib.attrNames hplipPlatforms; maintainers = with lib.maintainers; [ ttuegel ]; }; }