From e1f3d9e0aecf1603e87592d7dddc988b1b9fce81 Mon Sep 17 00:00:00 2001 From: Yueh-Shun Li Date: Tue, 4 Nov 2025 02:24:09 +0800 Subject: [PATCH] androidenv: fix name overriding Use `overrideAttrs` to specify the FOD name we want, instead of specifying `pname` and `version` and expect a broken overrideAttrs that won't update `name`. --- .../androidenv/compose-android-packages.nix | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/pkgs/development/mobile/androidenv/compose-android-packages.nix b/pkgs/development/mobile/androidenv/compose-android-packages.nix index 6222b629f8df..413759a5f88e 100644 --- a/pkgs/development/mobile/androidenv/compose-android-packages.nix +++ b/pkgs/development/mobile/androidenv/compose-android-packages.nix @@ -190,18 +190,21 @@ let map ( archive: (fetchurl { + pname = packageInfo.name; + version = packageInfo.revision; inherit (archive) url sha1; inherit meta; passthru = { info = packageInfo; }; }).overrideAttrs - (prev: { - # fetchurl won't generate the correct filename if we specify pname and version, - # and we still want the version attribute to show up in search, so specify these in an override - pname = packageInfo.name; - version = packageInfo.revision; - }) + ( + finalAttrs: previousAttrs: { + # fetchurl prioritize `pname` and `version` over the specified `name`, + # so specify custom `name` in an override. + name = baseNameOf (lib.head (finalAttrs.urls)); + } + ) ) validArchives ) )