From b64f57662dd82843e95f5f110ad1824070a159ce Mon Sep 17 00:00:00 2001 From: Fabian Affolter Date: Fri, 1 Sep 2023 14:42:36 +0200 Subject: [PATCH 1/4] python311Packages.slack-bolt: disable on unsupported Python releases --- pkgs/development/python-modules/slack-bolt/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/python-modules/slack-bolt/default.nix b/pkgs/development/python-modules/slack-bolt/default.nix index 30cf185c1aa7..f3c3e155b97c 100644 --- a/pkgs/development/python-modules/slack-bolt/default.nix +++ b/pkgs/development/python-modules/slack-bolt/default.nix @@ -25,6 +25,8 @@ buildPythonPackage rec { version = "1.18.0"; format = "setuptools"; + disabled = pythonOlder "3.7"; + src = fetchFromGitHub { owner = "slackapi"; repo = "bolt-python"; From 5fd650cb094bd7eb7d63d82d01850e4a93d12011 Mon Sep 17 00:00:00 2001 From: Fabian Affolter Date: Fri, 1 Sep 2023 15:51:45 +0200 Subject: [PATCH 2/4] python311Packages.slack-bolt: disable failing tests --- pkgs/development/python-modules/slack-bolt/default.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/development/python-modules/slack-bolt/default.nix b/pkgs/development/python-modules/slack-bolt/default.nix index f3c3e155b97c..ec298eb25a82 100644 --- a/pkgs/development/python-modules/slack-bolt/default.nix +++ b/pkgs/development/python-modules/slack-bolt/default.nix @@ -25,8 +25,6 @@ buildPythonPackage rec { version = "1.18.0"; format = "setuptools"; - disabled = pythonOlder "3.7"; - src = fetchFromGitHub { owner = "slackapi"; repo = "bolt-python"; @@ -68,6 +66,9 @@ buildPythonPackage rec { disabledTestPaths = [ # boddle is not packaged as of 2023-07-15 "tests/adapter_tests/bottle/" + # Tests are blocking at some point. Blocking could be performance-related. + "tests/scenario_tests_async/" + "tests/slack_bolt_async/" ]; disabledTests = [ From 133fa25eccb1d5aced1c58ac46d22e7dd434edbd Mon Sep 17 00:00:00 2001 From: Fabian Affolter Date: Fri, 1 Sep 2023 15:57:38 +0200 Subject: [PATCH 3/4] python311Packages.slack-bolt: add optional-dependencies --- .../python-modules/slack-bolt/default.nix | 54 +++++++++++++------ 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/pkgs/development/python-modules/slack-bolt/default.nix b/pkgs/development/python-modules/slack-bolt/default.nix index ec298eb25a82..eda95ae2dd26 100644 --- a/pkgs/development/python-modules/slack-bolt/default.nix +++ b/pkgs/development/python-modules/slack-bolt/default.nix @@ -1,4 +1,6 @@ -{ buildPythonPackage +{ aiohttp +, bottle +, buildPythonPackage , chalice , cherrypy , django @@ -7,17 +9,23 @@ , fetchFromGitHub , flask , flask-sockets +, gunicorn , lib , moto , numpy , pyramid , pytest-asyncio , pytestCheckHook +, pythonOlder , sanic , sanic-testing , slack-sdk , starlette , tornado +, uvicorn +, websocket-client +, websockets +, werkzeug }: buildPythonPackage rec { @@ -25,6 +33,8 @@ buildPythonPackage rec { version = "1.18.0"; format = "setuptools"; + disabled = pythonOlder "3.7"; + src = fetchFromGitHub { owner = "slackapi"; repo = "bolt-python"; @@ -40,23 +50,37 @@ buildPythonPackage rec { propagatedBuildInputs = [ slack-sdk ]; + passthru.optional-dependencies = { + async = [ + aiohttp + websockets + ]; + adapter = [ + bottle + chalice + cherrypy + django + falcon + fastapi + flask + flask-sockets + gunicorn + moto + pyramid + sanic + sanic-testing + starlette + tornado + uvicorn + websocket-client + werkzeug + ]; + }; + nativeCheckInputs = [ - chalice - cherrypy - django - falcon - fastapi - flask - flask-sockets - moto - pyramid pytest-asyncio pytestCheckHook - sanic - sanic-testing - starlette - tornado - ]; + ] ++ lib.flatten (builtins.attrValues passthru.optional-dependencies); # Work around "Read-only file system: '/homeless-shelter'" errors preCheck = '' From 1b5342ae3a0816f310bf282a629dcc174e443803 Mon Sep 17 00:00:00 2001 From: Fabian Affolter Date: Fri, 1 Sep 2023 16:19:41 +0200 Subject: [PATCH 4/4] python311Packages.slack-bolt: add changelog to meta --- pkgs/development/python-modules/slack-bolt/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/development/python-modules/slack-bolt/default.nix b/pkgs/development/python-modules/slack-bolt/default.nix index eda95ae2dd26..f732da1d5d3f 100644 --- a/pkgs/development/python-modules/slack-bolt/default.nix +++ b/pkgs/development/python-modules/slack-bolt/default.nix @@ -109,6 +109,7 @@ buildPythonPackage rec { meta = with lib; { description = "A framework to build Slack apps using Python"; homepage = "https://github.com/slackapi/bolt-python"; + changelog = "https://github.com/slackapi/bolt-python/releases/tag/v${version}"; license = licenses.mit; maintainers = with maintainers; [ samuela ]; };