From b6b9a78f416aab3fd882e6f4c64b54561dbddd83 Mon Sep 17 00:00:00 2001 From: Jason Yundt Date: Sat, 9 May 2026 17:51:10 -0400 Subject: [PATCH] sm64coopdx: Switch back to using tag instead of rev when fetching src MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before 1f2c3637d56ee36d6c05a498a69da6074d71087f, the sm64coopdx package fetched its source by doing this: > src = fetchFromGitHub { > owner = "coop-deluxe"; > repo = "sm64coopdx"; > tag = "v${finalAttrs.version}"; > hash = ""; > }; 1f2c3637d56ee36d6c05a498a69da6074d71087f made it so that the sm64coopdx package fetched its source by doing this: > src = fetchFromGitHub { > owner = "coop-deluxe"; > repo = "sm64coopdx"; > # Replace with `tag = "v${finalAttrs.version}";` in the next version. The upstream repository tagged the wrong commit. > rev = ""; > hash = "; > }; Switching from using ‘tag = "v${finalAttrs.version}";’ to ‘rev = "";’ was only necessary because of an upstream sm64coopdx bug [1]. Now that that bug has been fixed, we can switch back to using ‘tag = "v${finalAttrs.version}";’. [1]: --- pkgs/by-name/sm/sm64coopdx/package.nix | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/by-name/sm/sm64coopdx/package.nix b/pkgs/by-name/sm/sm64coopdx/package.nix index b9d3c42f86cd..42fab75dee7b 100644 --- a/pkgs/by-name/sm/sm64coopdx/package.nix +++ b/pkgs/by-name/sm/sm64coopdx/package.nix @@ -45,8 +45,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "coop-deluxe"; repo = "sm64coopdx"; - # Replace with `tag = "v${finalAttrs.version}";` in the next version. The upstream repository tagged the wrong commit. - rev = "6092488d1c4fc741b16a0789ef9c08ec0279333f"; + tag = "v${finalAttrs.version}"; hash = "sha256-BIdKKIp6q9Vp2DByXzT9CJzOszFhjriiWBEqFwUT28M="; };