From e10634f89b3b187333791069c6e462d2e8a216ac Mon Sep 17 00:00:00 2001
From: Sarah Clark <seclark@nextquestion.net>
Date: Tue, 13 Jan 2026 14:57:04 -0800
Subject: [PATCH] python314Packages.gilknocker: disable benchmarks (segfault)
 and flaky test on Darwin

---
 .../python-modules/gilknocker/default.nix     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/pkgs/development/python-modules/gilknocker/default.nix b/pkgs/development/python-modules/gilknocker/default.nix
index 29cf43a96c69..425fd25c40ef 100644
--- a/pkgs/development/python-modules/gilknocker/default.nix
+++ b/pkgs/development/python-modules/gilknocker/default.nix
@@ -1,7 +1,9 @@
 {
   lib,
+  stdenv,
   buildPythonPackage,
   fetchFromGitHub,
+  pythonAtLeast,
 
   # build-system
   pkg-config,
@@ -54,6 +56,24 @@ buildPythonPackage rec {
     pytest-rerunfailures
   ];
 
+  enabledTestPaths = [
+    # skip the benchmarks as they can segfault
+    # https://github.com/milesgranger/gilknocker/issues/35
+    "tests"
+  ];
+
+  disabledTestPaths = lib.optionals (pythonAtLeast "3.14") [
+    # segfaults
+    # https://github.com/milesgranger/gilknocker/issues/35
+    "benchmarks"
+  ];
+
+  disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [
+    # depends on an empirically-derived threshold that fails on fast and slow machines.
+    # https://github.com/milesgranger/gilknocker/issues/36
+    "test_knockknock_some_gil"
+  ];
+
   pytestFlags = [ "--benchmark-disable" ];
 
   meta = {