From abd5dfa01396942cf65cea34829e448ed4263950 Mon Sep 17 00:00:00 2001 From: figsoda Date: Wed, 24 May 2023 11:56:21 -0400 Subject: [PATCH 1/2] buildGoModule: remove unused `with builtins;` --- pkgs/build-support/go/module.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/build-support/go/module.nix b/pkgs/build-support/go/module.nix index 2c5d1827cdea..f1f25a92da30 100644 --- a/pkgs/build-support/go/module.nix +++ b/pkgs/build-support/go/module.nix @@ -55,8 +55,6 @@ , ... }@args': -with builtins; - assert goPackagePath != "" -> throw "`goPackagePath` is not needed with `buildGoModule`"; assert (vendorSha256 == "_unset" && vendorHash == "_unset") -> throw "either `vendorHash` or `vendorSha256` is required"; assert (vendorSha256 != "_unset" && vendorHash != "_unset") -> throw "both `vendorHash` and `vendorSha256` set. only one can be set."; From 3be02ada9e31503a779b5f79320ca80d5e8aee8c Mon Sep 17 00:00:00 2001 From: figsoda Date: Wed, 24 May 2023 11:58:12 -0400 Subject: [PATCH 2/2] buildGoModule: remove unused lambda parameters --- pkgs/build-support/go/module.nix | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkgs/build-support/go/module.nix b/pkgs/build-support/go/module.nix index f1f25a92da30..a70313a7a5ff 100644 --- a/pkgs/build-support/go/module.nix +++ b/pkgs/build-support/go/module.nix @@ -2,14 +2,10 @@ { name ? "${args'.pname}-${args'.version}" , src -, buildInputs ? [] , nativeBuildInputs ? [] , passthru ? {} , patches ? [] -# Go linker flags, passed to go via -ldflags -, ldflags ? [] - # Go tags, passed to go via -tag , tags ? []