From e05e9846892ea740ce26d8a07f74b82adf08b6fc Mon Sep 17 00:00:00 2001
From: Michael Daniels <mdaniels5757@gmail.com>
Date: Sat, 17 Jan 2026 20:59:12 -0500
Subject: [PATCH] ci/github-script/reviews: rework dismissal/non-posting logic

Dismissals are done automatically by commits.js, even for reviews from
check-target-branches.js. This is not desirable.

The solution is
(1) do not decline to post a review because it was already dismissed
    (because it may have not been dismissed by a human, and circumstances may
    have changed), and
(2) reword the auto-dismissal message to not imply that whatever
    problems were present are fixed.
---
 ci/github-script/reviews.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/ci/github-script/reviews.js b/ci/github-script/reviews.js
index f10f141d84cb..ef8f4272c02c 100644
--- a/ci/github-script/reviews.js
+++ b/ci/github-script/reviews.js
@@ -19,13 +19,13 @@ async function dismissReviews({ github, context, dry }) {
             ...context.repo,
             pull_number,
             review_id: review.id,
-            message: 'All good now, thank you!',
+            message: 'Review dismissed automatically',
           })
         }
         await github.graphql(
           `mutation($node_id:ID!) {
             minimizeComment(input: {
-              classifier: RESOLVED,
+              classifier: OUTDATED,
               subjectId: $node_id
             })
             { clientMutationId }
@@ -49,10 +49,7 @@ async function postReview({ github, context, core, dry, body }) {
       review.user?.login === 'github-actions[bot]' &&
       // If a review is still pending, we can just update this instead
       // of posting a new one.
-      (review.state === 'CHANGES_REQUESTED' ||
-        // No need to post a new review, if an older one with the exact
-        // same content had already been dismissed.
-        review.body === body),
+      review.state === 'CHANGES_REQUESTED',
   )
 
   if (dry) {