From df0c0570c87efa8f75f100462873c6acc4bccbc8 Mon Sep 17 00:00:00 2001 From: Emily Date: Fri, 8 Aug 2025 18:22:54 +0100 Subject: [PATCH] arangodb: drop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This requires an EOL GCC to build. The version is over two years old; the latest version is 3.12.5.2. The listed package maintainer [no longer uses the package]. If another version is packaged that builds with a supported compiler, this can be re‐added; per the [request from 2023] to restore versioned suffixes, it should likely not be upgraded in place anyway, to avoid unexpected data migrations. [no longer uses the package]: [request from 2023]: --- pkgs/by-name/ar/arangodb/package.nix | 94 ------------------- .../python-modules/python-arango/default.nix | 50 +++++----- pkgs/top-level/aliases.nix | 1 + 3 files changed, 28 insertions(+), 117 deletions(-) delete mode 100644 pkgs/by-name/ar/arangodb/package.nix diff --git a/pkgs/by-name/ar/arangodb/package.nix b/pkgs/by-name/ar/arangodb/package.nix deleted file mode 100644 index 8afc588a967e..000000000000 --- a/pkgs/by-name/ar/arangodb/package.nix +++ /dev/null @@ -1,94 +0,0 @@ -{ - # gcc 11.2 suggested on 3.10.5.2. - # gcc 11.3.0 unsupported yet, investigate gcc support when upgrading - # See https://github.com/arangodb/arangodb/issues/17454 - gcc10Stdenv, - git, - lib, - fetchFromGitHub, - openssl, - zlib, - cmake, - python3, - perl, - snappy, - lzo, - which, - targetArchitecture ? null, - asmOptimizations ? gcc10Stdenv.hostPlatform.isx86, -}: - -let - defaultTargetArchitecture = if gcc10Stdenv.hostPlatform.isx86 then "haswell" else "core"; - - targetArch = if targetArchitecture == null then defaultTargetArchitecture else targetArchitecture; -in - -gcc10Stdenv.mkDerivation rec { - pname = "arangodb"; - version = "3.10.5.2"; - - src = fetchFromGitHub { - repo = "arangodb"; - owner = "arangodb"; - tag = "v${version}"; - hash = "sha256-64iTxhG8qKTSrTlH/BWDJNnLf8VnaCteCKfQ9D2lGDQ="; - fetchSubmodules = true; - }; - - nativeBuildInputs = [ - cmake - git - perl - python3 - which - ]; - - buildInputs = [ - openssl - zlib - snappy - lzo - ]; - - # prevent failing with "cmake-3.13.4/nix-support/setup-hook: line 10: ./3rdParty/rocksdb/RocksDBConfig.cmake.in: No such file or directory" - dontFixCmake = true; - env.NIX_CFLAGS_COMPILE = "-Wno-error"; - - postPatch = '' - sed -i -e 's!/bin/echo!echo!' 3rdParty/V8/gypfiles/*.gypi - - # with nixpkgs, it has no sense to check for a version update - substituteInPlace js/client/client.js --replace "require('@arangodb').checkAvailableVersions();" "" - substituteInPlace js/server/server.js --replace "require('@arangodb').checkAvailableVersions();" "" - ''; - - preConfigure = '' - patchShebangs utils - ''; - - cmakeBuildType = "RelWithDebInfo"; - - cmakeFlags = [ - "-DUSE_MAINTAINER_MODE=OFF" - "-DUSE_GOOGLE_TESTS=OFF" - - # avoid reading /proc/cpuinfo for feature detection - "-DTARGET_ARCHITECTURE=${targetArch}" - ] - ++ lib.optionals asmOptimizations [ - "-DASM_OPTIMIZATIONS=ON" - "-DHAVE_SSE42=${if gcc10Stdenv.hostPlatform.sse4_2Support then "ON" else "OFF"}" - ]; - - meta = with lib; { - homepage = "https://www.arangodb.com"; - description = "Native multi-model database with flexible data models for documents, graphs, and key-values"; - license = licenses.asl20; - platforms = [ "x86_64-linux" ]; - maintainers = with maintainers; [ - flosse - jsoo1 - ]; - }; -} diff --git a/pkgs/development/python-modules/python-arango/default.nix b/pkgs/development/python-modules/python-arango/default.nix index d7acf848e061..76823eb509f2 100644 --- a/pkgs/development/python-modules/python-arango/default.nix +++ b/pkgs/development/python-modules/python-arango/default.nix @@ -18,7 +18,6 @@ packaging, # tests - arangodb, mock, }: @@ -61,11 +60,16 @@ buildPythonPackage rec { ]; nativeCheckInputs = [ - arangodb + #arangodb mock pytestCheckHook ]; + # ArangoDB has been removed from Nixpkgs due to lack of maintenace, + # so we cannot run the tests at present. + # + # Before that, the issue was: + # # arangodb is compiled only for particular target architectures # (i.e. "haswell"). Thus, these tests may not pass reproducibly, # failing with: `166: Illegal instruction` if not run on arangodb's @@ -76,27 +80,27 @@ buildPythonPackage rec { # architecture issues will be irrelevant. doCheck = false; - preCheck = lib.optionalString doCheck '' - # Start test DB - mkdir -p .nix-test/{data,work} - - ICU_DATA=${arangodb}/share/arangodb3 \ - GLIBCXX_FORCE_NEW=1 \ - TZ=UTC \ - TZ_DATA=${arangodb}/share/arangodb3/tzdata \ - ARANGO_ROOT_PASSWORD=${testDBOpts.password} \ - ${arangodb}/bin/arangod \ - --server.uid=$(id -u) \ - --server.gid=$(id -g) \ - --server.authentication=true \ - --server.endpoint=http+tcp://${testDBOpts.host}:${testDBOpts.port} \ - --server.descriptors-minimum=4096 \ - --server.jwt-secret=${testDBOpts.secret} \ - --javascript.app-path=.nix-test/app \ - --log.file=.nix-test/log \ - --database.directory=.nix-test/data \ - --foxx.api=false & - ''; + #preCheck = lib.optionalString doCheck '' + # # Start test DB + # mkdir -p .nix-test/{data,work} + # + # ICU_DATA=${arangodb}/share/arangodb3 \ + # GLIBCXX_FORCE_NEW=1 \ + # TZ=UTC \ + # TZ_DATA=${arangodb}/share/arangodb3/tzdata \ + # ARANGO_ROOT_PASSWORD=${testDBOpts.password} \ + # ${arangodb}/bin/arangod \ + # --server.uid=$(id -u) \ + # --server.gid=$(id -g) \ + # --server.authentication=true \ + # --server.endpoint=http+tcp://${testDBOpts.host}:${testDBOpts.port} \ + # --server.descriptors-minimum=4096 \ + # --server.jwt-secret=${testDBOpts.secret} \ + # --javascript.app-path=.nix-test/app \ + # --log.file=.nix-test/log \ + # --database.directory=.nix-test/data \ + # --foxx.api=false & + #''; pytestFlags = [ "--host=${testDBOpts.host}" diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index 200ac0ede7c9..aa804154bc1d 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -459,6 +459,7 @@ mapAliases { apple-sdk_10_14 = throw "apple-sdk_10_14 was removed as Nixpkgs no longer supprots macOS 10.14; see the 25.05 release notes"; # Added 2024-10-27 apple-sdk_10_15 = throw "apple-sdk_10_15 was removed as Nixpkgs no longer supports macOS 10.15; see the 25.05 release notes"; # Added 2024-10-27 appthreat-depscan = dep-scan; # Added 2024-04-10 + arangodb = throw "arangodb has been removed, as it was unmaintained and the packaged version does not build with supported GCC versions"; # Added 2025-08-12 arb = throw "'arb' has been removed as it has been merged into 'flint3'"; # Added 2025-03-28 arcanist = throw "arcanist was removed as phabricator is not supported and does not accept fixes"; # Added 2024-06-07 archipelago-minecraft = throw "archipelago-minecraft has been removed, as upstream no longer ships minecraft as a default APWorld."; # Added 2025-07-15