From c99cac72c69871429239d7e86d5c03ad5c01f50c Mon Sep 17 00:00:00 2001 From: Kira Bruneau Date: Sun, 3 Nov 2024 17:59:30 -0500 Subject: [PATCH] zynaddsubfx: disable PortChecker test unconditionally We discovered that the PortChecker test is non-deterministic in #353482. There's a fix upstream: https://github.com/zynaddsubfx/zynaddsubfx/pull/244, but it requires an update to one of the submodules, rtosc. So for now, we'll just disable the test until the next release. --- pkgs/applications/audio/zynaddsubfx/default.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/audio/zynaddsubfx/default.nix b/pkgs/applications/audio/zynaddsubfx/default.nix index 59f0310263a4..b419ec217a80 100644 --- a/pkgs/applications/audio/zynaddsubfx/default.nix +++ b/pkgs/applications/audio/zynaddsubfx/default.nix @@ -117,9 +117,10 @@ in stdenv.mkDerivation rec { # TODO: Update cmake hook to make it simpler to selectively disable cmake tests: #113829 checkPhase = let disabledTests = - # PortChecker test fails when lashSupport is enabled because - # zynaddsubfx takes to long to start trying to connect to lash - lib.optionals lashSupport [ "PortChecker" ] + # PortChecker is non-deterministic. It's fixed in the master + # branch, but backporting would require an update to rtosc, so + # we'll just disable it until the next release. + [ "PortChecker" ] # Tests fail on aarch64 ++ lib.optionals stdenv.hostPlatform.isAarch64 [ "MessageTest" "UnisonTest" ];