From 6f4d3e3c2c5f1d6fcbf730e634ebfed4ac5ab88b Mon Sep 17 00:00:00 2001 From: Jon Seager Date: Fri, 13 Jun 2025 14:35:17 +0100 Subject: [PATCH 1/4] charmcraft: 3.5.0 -> 3.5.1 --- pkgs/by-name/ch/charmcraft/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/ch/charmcraft/package.nix b/pkgs/by-name/ch/charmcraft/package.nix index 8d39d10f6837..a91da79c447c 100644 --- a/pkgs/by-name/ch/charmcraft/package.nix +++ b/pkgs/by-name/ch/charmcraft/package.nix @@ -32,7 +32,7 @@ let in python.pkgs.buildPythonApplication rec { pname = "charmcraft"; - version = "3.5.0"; + version = "3.5.1"; pyproject = true; @@ -40,7 +40,7 @@ python.pkgs.buildPythonApplication rec { owner = "canonical"; repo = "charmcraft"; tag = version; - hash = "sha256-NIOfjd4r9mDP0x1IpIVJlU+Aza0a17bc3jDxtInrf4A="; + hash = "sha256-4zlUHttny6nIRhx/5aDz2sh1Va0+nN+7cezBGtt5Img="; }; postPatch = '' From 4508894dbd0ff8d08168fa6e685bdb99914da3cf Mon Sep 17 00:00:00 2001 From: Jon Seager Date: Fri, 13 Jun 2025 14:35:49 +0100 Subject: [PATCH 2/4] snapcraft: 8.9.2 -> 8.9.4 --- pkgs/by-name/sn/snapcraft/package.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sn/snapcraft/package.nix b/pkgs/by-name/sn/snapcraft/package.nix index 630f8dce0f74..d8378dc610bd 100644 --- a/pkgs/by-name/sn/snapcraft/package.nix +++ b/pkgs/by-name/sn/snapcraft/package.nix @@ -14,7 +14,7 @@ python312Packages.buildPythonApplication rec { pname = "snapcraft"; - version = "8.9.2"; + version = "8.9.4"; pyproject = true; @@ -22,7 +22,7 @@ python312Packages.buildPythonApplication rec { owner = "canonical"; repo = "snapcraft"; tag = version; - hash = "sha256-4Dv2q/aKWnQkQ6ANYev/5fT1fFKh1MytYJtHK0iAzhk="; + hash = "sha256-iiz+sVncztaCNndU+4YMhxECw7R6ks+25apRnd0WgyM="; }; patches = [ @@ -111,6 +111,7 @@ python312Packages.buildPythonApplication rec { "docutils" "jsonschema" "pygit2" + "requests" "urllib3" "validators" ]; From fa88a0570fc2e54da43f9168fc9b56efe232dd35 Mon Sep 17 00:00:00 2001 From: Jon Seager Date: Sat, 14 Jun 2025 14:01:06 +0100 Subject: [PATCH 3/4] python3Packages.craft-parts: disable x86_64 specific tests on aarch64 --- pkgs/development/python-modules/craft-parts/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/python-modules/craft-parts/default.nix b/pkgs/development/python-modules/craft-parts/default.nix index 279e41668dbe..9f1447fe3bfc 100644 --- a/pkgs/development/python-modules/craft-parts/default.nix +++ b/pkgs/development/python-modules/craft-parts/default.nix @@ -109,6 +109,8 @@ buildPythonPackage rec { # These tests have hardcoded "amd64" strings which fail on aarch64 "tests/unit/executor/test_environment.py" "tests/unit/features/overlay/test_executor_environment.py" + # Hard-coded assumptions about arguments relating to 'x86_64' + "tests/unit/plugins/test_dotnet_v2_plugin.py" ]; passthru.updateScript = nix-update-script { }; From 752deb82fd0bf408ff624b1642c541fe3b3022ea Mon Sep 17 00:00:00 2001 From: Jon Seager Date: Mon, 16 Jun 2025 09:17:23 +0100 Subject: [PATCH 4/4] python3Packages.craft-application: disable x86_64 specific tests on aarch64 --- pkgs/by-name/ch/charmcraft/package.nix | 12 ++++++++++++ .../craft-application/default.nix | 17 +++++++++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/pkgs/by-name/ch/charmcraft/package.nix b/pkgs/by-name/ch/charmcraft/package.nix index a91da79c447c..6f5707243d6f 100644 --- a/pkgs/by-name/ch/charmcraft/package.nix +++ b/pkgs/by-name/ch/charmcraft/package.nix @@ -7,6 +7,7 @@ cacert, versionCheckHook, writableTmpDirAsHomeHook, + stdenv, }: let version = "4.10.0"; @@ -26,6 +27,17 @@ let substituteInPlace pyproject.toml --replace-fail "setuptools==75.8.0" "setuptools" substituteInPlace craft_application/git/_git_repo.py --replace-fail "/snap/core22/current/etc/ssl/certs" "${cacert}/etc/ssl/certs" ''; + + disabledTestPaths = [ + # These tests assert outputs of commands that assume Ubuntu-related output. + "tests/unit/services/test_lifecycle.py" + ]; + + disabledTests = + old.disabledTests + ++ lib.optionals stdenv.hostPlatform.isAarch64 [ + "test_process_grammar_full" + ]; }); }; }; diff --git a/pkgs/development/python-modules/craft-application/default.nix b/pkgs/development/python-modules/craft-application/default.nix index 8951c8982519..ec71f3dd4b4c 100644 --- a/pkgs/development/python-modules/craft-application/default.nix +++ b/pkgs/development/python-modules/craft-application/default.nix @@ -127,12 +127,21 @@ buildPythonPackage rec { "test_process_grammar_build_for" "test_process_grammar_platform" "test_process_grammar_default" + "test_create_craft_manifest" + "test_create_project_manifest" + "test_from_packed_artifact" + "test_teardown_session_create_manifest" ]; - disabledTestPaths = [ - # These tests assert outputs of commands that assume Ubuntu-related output. - "tests/unit/services/test_lifecycle.py" - ]; + disabledTestPaths = + [ + # These tests assert outputs of commands that assume Ubuntu-related output. + "tests/unit/services/test_lifecycle.py" + ] + ++ lib.optionals stdenv.hostPlatform.isAarch64 [ + # Hard-coded assumptions around use of "amd64" arch strings. + "tests/unit/services/test_project.py" + ]; passthru.updateScript = nix-update-script { };