From db04185bc923d2b168a5dd3b2aa05b7627fda5d6 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 22 Nov 2023 16:46:03 -0800 Subject: [PATCH 1/5] steam.runtime-wrapped: use throw, not abort --- pkgs/games/steam/runtime-wrapped.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/games/steam/runtime-wrapped.nix b/pkgs/games/steam/runtime-wrapped.nix index 3b6cfcd6ee12..648e012d3fe5 100644 --- a/pkgs/games/steam/runtime-wrapped.nix +++ b/pkgs/games/steam/runtime-wrapped.nix @@ -21,7 +21,7 @@ let gnuArch = if steamArch == "amd64" then "x86_64-linux-gnu" else if steamArch == "i386" then "i386-linux-gnu" - else abort "Unsupported architecture"; + else throw "Unsupported architecture"; libs = [ "lib/${gnuArch}" "lib" "usr/lib/${gnuArch}" "usr/lib" ]; bins = [ "bin" "usr/bin" ]; From c946245c7a595c0834d3787ce4215419fc3df73b Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 22 Nov 2023 16:43:48 -0800 Subject: [PATCH 2/5] tests.nixops: fix broken eval --- nixos/tests/nixops/default.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nixos/tests/nixops/default.nix b/nixos/tests/nixops/default.nix index b8f747b2a19f..f7a26f2461c4 100644 --- a/nixos/tests/nixops/default.nix +++ b/nixos/tests/nixops/default.nix @@ -1,4 +1,6 @@ -{ pkgs, ... }: +{ pkgs +, testers +, ... }: let inherit (pkgs) lib; @@ -19,7 +21,7 @@ let passthru.override = args': testsForPackage (args // args'); }; - testLegacyNetwork = { nixopsPkg, ... }: pkgs.nixosTest ({ + testLegacyNetwork = { nixopsPkg, ... }: testers.nixosTest ({ name = "nixops-legacy-network"; nodes = { deployer = { config, lib, nodes, pkgs, ... }: { From 23f800e6ac0dd4742ccc7bec65d3455318ba50f1 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 22 Nov 2023 16:44:56 -0800 Subject: [PATCH 3/5] dockapps.wmsm-app: fix broken eval --- pkgs/by-name/wi/windowmaker/dockapps/wmsm-app.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/wi/windowmaker/dockapps/wmsm-app.nix b/pkgs/by-name/wi/windowmaker/dockapps/wmsm-app.nix index 6becfce9578b..36b555a81dd4 100644 --- a/pkgs/by-name/wi/windowmaker/dockapps/wmsm-app.nix +++ b/pkgs/by-name/wi/windowmaker/dockapps/wmsm-app.nix @@ -12,7 +12,7 @@ stdenv.mkDerivation (finalAttrs: { inherit (dockapps-sources) version src; - sourceRoot = "${src.name}/wmsm.app/wmsm"; + sourceRoot = "${finalAttrs.src.name}/wmsm.app/wmsm"; buildInputs = [ libX11 From 920e6f7eaae67a7e5c325038b8df3050e5198646 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 22 Nov 2023 16:45:18 -0800 Subject: [PATCH 4/5] dockapps.wmsystemtray: fix broken eval --- pkgs/by-name/wi/windowmaker/dockapps/wmsystemtray.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/wi/windowmaker/dockapps/wmsystemtray.nix b/pkgs/by-name/wi/windowmaker/dockapps/wmsystemtray.nix index 7f17475d318f..52ba4dacd0c2 100644 --- a/pkgs/by-name/wi/windowmaker/dockapps/wmsystemtray.nix +++ b/pkgs/by-name/wi/windowmaker/dockapps/wmsystemtray.nix @@ -33,8 +33,8 @@ stdenv.mkDerivation (finalAttrs: { meta = { description = "A system tray for Windowmaker"; homepage = "http://wmsystemtray.sourceforge.net"; - license = licenses.gpl2Only; + license = lib.licenses.gpl2Only; maintainers = [ ]; - platforms = platforms.linux; + platforms = lib.platforms.linux; }; }) From 1ac5c75337acc65754932e98c6c45b8298e8ab00 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 22 Nov 2023 16:46:21 -0800 Subject: [PATCH 5/5] amdgpu-pro: make error message actionable --- pkgs/os-specific/linux/amdgpu-pro/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/amdgpu-pro/default.nix b/pkgs/os-specific/linux/amdgpu-pro/default.nix index 241145a24843..96339c1d164f 100644 --- a/pkgs/os-specific/linux/amdgpu-pro/default.nix +++ b/pkgs/os-specific/linux/amdgpu-pro/default.nix @@ -27,7 +27,7 @@ let "i386-linux-gnu" else if stdenv.hostPlatform.system == "x86_64-linux" then "x86_64-linux-gnu" - else throw "amdgpu-pro is Linux only. Sorry."; + else throw "amdgpu-pro is Linux only. Sorry ${stdenv.hostPlatform.system}."; in stdenv.mkDerivation rec {