From 1af18e36bfdd7364e81a2e31e1807b875bcb4202 Mon Sep 17 00:00:00 2001 From: Charlotte Hartmann Paludo Date: Fri, 5 Dec 2025 10:57:55 +0100 Subject: [PATCH] nixos/ddclient: fix missing 'password=' config key The `password=` prefix was missing for the `protocol == nsupdate` and `secretsFile != null` cases. As a result, there's a line in the generated config file containing only the path to the secrets file / the `secrets_placeholder`, which `ddclient` interprets as a hostname for which to update a DNS entry, which won't work for obvious reasons. --- nixos/modules/services/networking/ddclient.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nixos/modules/services/networking/ddclient.nix b/nixos/modules/services/networking/ddclient.nix index 773387939a7c..826e387383a6 100644 --- a/nixos/modules/services/networking/ddclient.nix +++ b/nixos/modules/services/networking/ddclient.nix @@ -20,11 +20,11 @@ let ${lib.optionalString (cfg.username != "") "login=${cfg.username}"} ${ if cfg.protocol == "nsupdate" then - "/run/${RuntimeDirectory}/ddclient.key" + "password=/run/${RuntimeDirectory}/ddclient.key" else if (cfg.passwordFile != null) then "password=@password_placeholder@" else if (cfg.secretsFile != null) then - "@secrets_placeholder@" + "password=@secrets_placeholder@" else "" }