From d733d5558ae79f8d2793cbc9af87ffdea230f98a Mon Sep 17 00:00:00 2001 From: Grimmauld Date: Fri, 21 Mar 2025 10:43:43 +0100 Subject: [PATCH] graphviz: drop libXaw and libXpm dependencies The test build intended for debian [1] uses these dependencies as build time dependencies only. The arch package [2] does not use these dependencies at all. libXaw was added 11 years ago in 08131bd5d5f627f03625cf28ca8afbd7eb83e7fa. On arch, xterm links in libXaw and is used for vimdot support. However, the xterm nix package also explicitly links libXaw [3], and vimdot generally works. The build succeeds, and with vimdot working (through xwayland), this seems fully non-breaking. This change will drop libXaw from being a mass rebuild. While libXaw seems somewhat maintained, recent releases [4] are not even signed anymore, thus probably should not be a core component of nix packages. [1] https://gitlab.com/graphviz/graphviz/-/blob/2649f2366435525085cc79fb1e95ec23c84eb047/debian/control#L6 [2] https://archlinux.org/packages/extra/x86_64/graphviz/ [3] https://github.com/NixOS/nixpkgs/blob/a84ebe20c6bc2ecbcfb000a50776219f48d134cc/pkgs/by-name/xt/xterm/package.nix#L40 [4] https://gitlab.freedesktop.org/xorg/lib/libxaw/-/tags# --- pkgs/tools/graphics/graphviz/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/graphics/graphviz/default.nix b/pkgs/tools/graphics/graphviz/default.nix index d612a7f3fcdf..79f5bac7f88c 100644 --- a/pkgs/tools/graphics/graphviz/default.nix +++ b/pkgs/tools/graphics/graphviz/default.nix @@ -58,7 +58,7 @@ stdenv.mkDerivation rec { gts pango bash - ] ++ optionals withXorg (with xorg; [ libXrender libXaw libXpm ]) + ] ++ optionals withXorg (with xorg; [ libXrender ]) ++ optionals stdenv.hostPlatform.isDarwin [ ApplicationServices Foundation ]; hardeningDisable = [ "fortify" ];