From 7fa6d08468c113bf436ca93454e625d2365e1b4b Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Tue, 30 Jun 2026 22:34:11 +0000
Subject: [PATCH] python3Packages.facenet-pytorch: cleanup, fix

---
 .../facenet-pytorch/default.nix               | 46 +++++++++++++------
 1 file changed, 31 insertions(+), 15 deletions(-)

diff --git a/pkgs/development/python-modules/facenet-pytorch/default.nix b/pkgs/development/python-modules/facenet-pytorch/default.nix
index 9e8a0b21df1e..893d5bf43f68 100644
--- a/pkgs/development/python-modules/facenet-pytorch/default.nix
+++ b/pkgs/development/python-modules/facenet-pytorch/default.nix
@@ -1,34 +1,50 @@
 {
-  buildPythonPackage,
-  fetchPypi,
-  pillow,
-  torchvision,
   lib,
+  buildPythonPackage,
+  fetchFromGitHub,
+
+  # build-system
+  setuptools,
+
+  # dependencies
+  pillow,
+  requests,
+  torchvision,
 }:
 
-buildPythonPackage rec {
+buildPythonPackage (finalAttrs: {
   pname = "facenet-pytorch";
   version = "2.5.3";
-  format = "setuptools";
+  pyproject = true;
+  __structuredAttrs = true;
 
-  src = fetchPypi {
-    inherit pname version;
-    hash = "sha256-mMxbQqSPg3wCPrkvKlcc1KxqRmh8XnG56ZtJEIcnPis=";
+  src = fetchFromGitHub {
+    owner = "timesler";
+    repo = "facenet-pytorch";
+    tag = "v${finalAttrs.version}";
+    hash = "sha256-3YVyqKgVLD5aePwyVQA8kOiqx32kqg9lxU2uwPWGkCU=";
   };
 
-  doCheck = false; # pypi version doesn't ship with tests
+  build-system = [
+    setuptools
+  ];
+
+  dependencies = [
+    pillow
+    requests
+    torchvision
+  ];
 
   pythonImportsCheck = [ "facenet_pytorch" ];
 
-  propagatedBuildInputs = [
-    pillow
-    torchvision
-  ];
+  # The only tests require internet access
+  doCheck = false;
 
   meta = {
     description = "Pretrained Pytorch face detection (MTCNN) and facial recognition (InceptionResnet) models";
     homepage = "https://github.com/timesler/facenet-pytorch";
+    changelog = "https://github.com/timesler/facenet-pytorch/releases/tag/${finalAttrs.src.tag}";
     license = lib.licenses.mit;
     maintainers = [ ];
   };
-}
+})