From 7eafdd491c556a52b79c8c1eb5865730186b1fc0 Mon Sep 17 00:00:00 2001 From: Mynacol Date: Tue, 12 May 2026 10:10:00 +0000 Subject: [PATCH] deno: cleanup install version checks Remove redundant version test and replace the manual installCheckPhase with versionCheckHook. --- pkgs/by-name/de/deno/package.nix | 8 ++------ pkgs/by-name/de/deno/tests/default.nix | 6 ------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/pkgs/by-name/de/deno/package.nix b/pkgs/by-name/de/deno/package.nix index bcc620b3d62d..dc7687b9bedf 100644 --- a/pkgs/by-name/de/deno/package.nix +++ b/pkgs/by-name/de/deno/package.nix @@ -9,6 +9,7 @@ protobuf, installShellFiles, makeBinaryWrapper, + versionCheckHook, librusty_v8 ? callPackage ./rusty-v8 { }, libffi, sqlite, @@ -234,12 +235,7 @@ rustPlatform.buildRustPackage (finalAttrs: { ''; doInstallCheck = canExecute; - installCheckPhase = lib.optionalString canExecute '' - runHook preInstallCheck - $out/bin/deno --help - $out/bin/deno --version | grep "deno ${finalAttrs.version}" - runHook postInstallCheck - ''; + nativeInstallCheckInputs = [ versionCheckHook ]; passthru = { updateScript = ./update.sh; diff --git a/pkgs/by-name/de/deno/tests/default.nix b/pkgs/by-name/de/deno/tests/default.nix index c28490ee0d00..1cd80b77a389 100644 --- a/pkgs/by-name/de/deno/tests/default.nix +++ b/pkgs/by-name/de/deno/tests/default.nix @@ -71,9 +71,3 @@ in dir = ./read-file; }; }) -// { - version = testers.testVersion { - package = deno; - command = "deno --version"; - }; -}