From 078ebb0fe8c9c30639fdf3fb1e8af8a582319c9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 17 Jul 2023 15:41:37 +0200 Subject: [PATCH 1/2] libgit2: 1.6.4 -> 1.7.0 Diff: https://github.com/libgit2/libgit2/compare/v1.6.4...v1.7.0 --- pkgs/development/libraries/libgit2/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/libraries/libgit2/default.nix b/pkgs/development/libraries/libgit2/default.nix index 3d7b6ff9e012..ff7cefa5267a 100644 --- a/pkgs/development/libraries/libgit2/default.nix +++ b/pkgs/development/libraries/libgit2/default.nix @@ -19,14 +19,14 @@ stdenv.mkDerivation rec { pname = "libgit2"; - version = "1.6.4"; + version = "1.7.0"; # also check the following packages for updates: python3Packages.pygit2 and libgit2-glib src = fetchFromGitHub { owner = "libgit2"; repo = "libgit2"; rev = "v${version}"; - hash = "sha256-lW3mokVKsbknVj2xsxEbeZH4IdKZ0aIgGutzenS0Eh0="; + hash = "sha256-3ZVBGd2T5DQKsDEc5a7pS0yz01+rDCszU9ZK0zxvfyQ="; }; cmakeFlags = [ From de3e686cc895d81d6fa53f60463bb4eb6db9677e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 17 Jul 2023 16:07:40 +0200 Subject: [PATCH 2/2] python310Packages.pygit2: pin libgit2 to libgit2, run tests again --- .../python-modules/pygit2/default.nix | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/pkgs/development/python-modules/pygit2/default.nix b/pkgs/development/python-modules/pygit2/default.nix index 0ce6dc642448..e7360816691d 100644 --- a/pkgs/development/python-modules/pygit2/default.nix +++ b/pkgs/development/python-modules/pygit2/default.nix @@ -4,6 +4,7 @@ , cacert , cached-property , cffi +, fetchFromGitHub , fetchPypi , isPyPy , libgit2 @@ -12,6 +13,19 @@ , pythonOlder }: +let + libgit2' = libgit2.overrideAttrs (_: rec { + version = "1.6.4"; + + src = fetchFromGitHub { + owner = "libgit2"; + repo = "libgit2"; + rev = "v${version}"; + hash = "sha256-lW3mokVKsbknVj2xsxEbeZH4IdKZ0aIgGutzenS0Eh0="; + }; + }); +in + buildPythonPackage rec { pname = "pygit2"; version = "1.12.2"; @@ -29,7 +43,7 @@ buildPythonPackage rec { ''; buildInputs = [ - libgit2 + libgit2' ]; propagatedBuildInputs = [ @@ -58,14 +72,6 @@ buildPythonPackage rec { # https://github.com/NixOS/nixpkgs/pull/72544#issuecomment-582674047 SSL_CERT_FILE = "${cacert}/etc/ssl/certs/ca-bundle.crt"; - # setup.py check is broken - # https://github.com/libgit2/pygit2/issues/868 - dontUseSetuptoolsCheck = true; - - # TODO: Test collection is failing - # https://github.com/NixOS/nixpkgs/pull/72544#issuecomment-582681068 - doCheck = false; - pythonImportsCheck = [ "pygit2" ];