From a8cf34bf8447aae03993fc2a7e33ff444c9a9364 Mon Sep 17 00:00:00 2001 From: Ryan Hendrickson Date: Thu, 13 Mar 2025 22:16:28 -0400 Subject: [PATCH] firefox-devedition-unwrapped: fix branding --- pkgs/applications/networking/browsers/firefox/common.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index 7d822e6efdf6..2cfd599a3be0 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -481,7 +481,9 @@ buildStdenv.mkDerivation { (enableFeature enableDebugSymbols "debug-symbols") ] ++ lib.optionals enableDebugSymbols [ "--disable-strip" "--disable-install-strip" ] - ++ lib.optional enableOfficialBranding "--enable-official-branding" + # As of Firefox 137 (https://bugzilla.mozilla.org/show_bug.cgi?id=1943009), + # the --enable-official-branding flag overrides the --with-branding flag. + ++ lib.optional (enableOfficialBranding && branding == null) "--enable-official-branding" ++ lib.optional (branding != null) "--with-branding=${branding}" ++ extraConfigureFlags;