From 6805615be3f5d34bf0b7b49760d66804ccbad13d Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Sun, 30 Jun 2024 18:07:18 +0300 Subject: [PATCH 1/3] python311Packages.scipy: remove unrequired pythonOlder check --- pkgs/development/python-modules/scipy/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/scipy/default.nix b/pkgs/development/python-modules/scipy/default.nix index 92c1988c639d..0addc81776f7 100644 --- a/pkgs/development/python-modules/scipy/default.nix +++ b/pkgs/development/python-modules/scipy/default.nix @@ -6,7 +6,6 @@ fetchurl, writeText, python, - pythonOlder, buildPythonPackage, cython, gfortran, @@ -22,7 +21,6 @@ numpy, pybind11, pooch, - libxcrypt, xsimd, blas, lapack, @@ -108,7 +106,7 @@ buildPythonPackage { pybind11 pooch xsimd - ] ++ lib.optionals (pythonOlder "3.9") [ libxcrypt ]; + ]; propagatedBuildInputs = [ numpy ]; From 0b1ae52fe3225e6e1bfb1951a8bb287fc2df8f25 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Sun, 30 Jun 2024 18:35:05 +0300 Subject: [PATCH 2/3] python312Packages.scipy: add xcbuild for darwin build --- pkgs/development/python-modules/scipy/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/development/python-modules/scipy/default.nix b/pkgs/development/python-modules/scipy/default.nix index 0addc81776f7..22e7dba0c314 100644 --- a/pkgs/development/python-modules/scipy/default.nix +++ b/pkgs/development/python-modules/scipy/default.nix @@ -5,6 +5,7 @@ fetchpatch, fetchurl, writeText, + xcbuild, python, buildPythonPackage, cython, @@ -98,6 +99,12 @@ buildPythonPackage { pkg-config wheel setuptools + ] ++ lib.optionals stdenv.isDarwin [ + # Minimal version required according to: + # https://github.com/scipy/scipy/blob/v1.14.0/scipy/meson.build#L185-L188 + (xcbuild.override { + sdkVer = "13.3"; + }) ]; buildInputs = [ From bfeaaa19d7f89346e3b22f1047bb13dd36a617b5 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Sun, 30 Jun 2024 18:50:15 +0300 Subject: [PATCH 3/3] python312Packages.scipy: mention possible support for Darwin's Accelerate --- pkgs/development/python-modules/scipy/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/development/python-modules/scipy/default.nix b/pkgs/development/python-modules/scipy/default.nix index 22e7dba0c314..43e256b1fba6 100644 --- a/pkgs/development/python-modules/scipy/default.nix +++ b/pkgs/development/python-modules/scipy/default.nix @@ -23,6 +23,10 @@ pybind11, pooch, xsimd, + # Upstream has support for using Darwin's Accelerate package. However this + # requires a Darwin user to work on a nice way to do that via an override. + # See: + # https://github.com/scipy/scipy/blob/v1.14.0/scipy/meson.build#L194-L211 blas, lapack,