From c9c945c64d0506621291ddee9c263008fb361618 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Fri, 7 Feb 2025 15:58:56 +0200 Subject: [PATCH 1/5] rectangle: `rec` -> `finalAttrs` --- pkgs/by-name/re/rectangle/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/re/rectangle/package.nix b/pkgs/by-name/re/rectangle/package.nix index 937f06e8e6a3..5a10d387bcad 100644 --- a/pkgs/by-name/re/rectangle/package.nix +++ b/pkgs/by-name/re/rectangle/package.nix @@ -6,12 +6,12 @@ gitUpdater, }: -stdenvNoCC.mkDerivation rec { +stdenvNoCC.mkDerivation (finalAttrs: { pname = "rectangle"; version = "0.85"; src = fetchurl { - url = "https://github.com/rxhanson/Rectangle/releases/download/v${version}/Rectangle${version}.dmg"; + url = "https://github.com/rxhanson/Rectangle/releases/download/v${finalAttrs.version}/Rectangle${finalAttrs.version}.dmg"; hash = "sha256-TBUC5z2BZMt0eb9NAD3/y9y23iRzs7YRJSfyb3QN1Mc="; }; @@ -44,4 +44,4 @@ stdenvNoCC.mkDerivation rec { ]; license = licenses.mit; }; -} +}) From b92c4b3df62f9db3045d6e15da1e63c5930e8fd3 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Fri, 7 Feb 2025 16:01:27 +0200 Subject: [PATCH 2/5] rectangle: refactor `meta` --- pkgs/by-name/re/rectangle/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/re/rectangle/package.nix b/pkgs/by-name/re/rectangle/package.nix index 5a10d387bcad..eefe589ebf54 100644 --- a/pkgs/by-name/re/rectangle/package.nix +++ b/pkgs/by-name/re/rectangle/package.nix @@ -33,15 +33,15 @@ stdenvNoCC.mkDerivation (finalAttrs: { rev-prefix = "v"; }; - meta = with lib; { + meta = { description = "Move and resize windows in macOS using keyboard shortcuts or snap areas"; homepage = "https://rectangleapp.com/"; - sourceProvenance = with sourceTypes; [ binaryNativeCode ]; - platforms = platforms.darwin; - maintainers = with maintainers; [ + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ Intuinewin wegank ]; - license = licenses.mit; + platforms = lib.platforms.darwin; + sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; }; }) From 94748ce2764a6e2d952ff6786ed9700337c808dc Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Fri, 7 Feb 2025 16:02:01 +0200 Subject: [PATCH 3/5] rectangle: `gitUpdater` -> `nix-update-script` --- pkgs/by-name/re/rectangle/package.nix | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/re/rectangle/package.nix b/pkgs/by-name/re/rectangle/package.nix index eefe589ebf54..31b35cb8a3d9 100644 --- a/pkgs/by-name/re/rectangle/package.nix +++ b/pkgs/by-name/re/rectangle/package.nix @@ -3,7 +3,7 @@ stdenvNoCC, fetchurl, undmg, - gitUpdater, + nix-update-script, }: stdenvNoCC.mkDerivation (finalAttrs: { @@ -28,10 +28,7 @@ stdenvNoCC.mkDerivation (finalAttrs: { runHook postInstall ''; - passthru.updateScript = gitUpdater { - url = "https://github.com/rxhanson/Rectangle"; - rev-prefix = "v"; - }; + passthru.updateScript = nix-update-script { }; meta = { description = "Move and resize windows in macOS using keyboard shortcuts or snap areas"; From af4ce091cfcdb6ddcc1fe967fca2cd9f91c44a22 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Fri, 7 Feb 2025 16:02:43 +0200 Subject: [PATCH 4/5] rectangle: quote paths --- pkgs/by-name/re/rectangle/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/re/rectangle/package.nix b/pkgs/by-name/re/rectangle/package.nix index 31b35cb8a3d9..a2a2f9bfd991 100644 --- a/pkgs/by-name/re/rectangle/package.nix +++ b/pkgs/by-name/re/rectangle/package.nix @@ -22,8 +22,8 @@ stdenvNoCC.mkDerivation (finalAttrs: { installPhase = '' runHook preInstall - mkdir -p $out/Applications - mv Rectangle.app $out/Applications + mkdir -p "$out/Applications" + mv Rectangle.app "$out/Applications" runHook postInstall ''; From f76e8263836d5d07604889de30c2e83950a96095 Mon Sep 17 00:00:00 2001 From: DontEatOreo <57304299+DontEatOreo@users.noreply.github.com> Date: Fri, 7 Feb 2025 14:03:25 +0000 Subject: [PATCH 5/5] rectangle: 0.85 -> 0.86 Changelog: https://github.com/rxhanson/Rectangle/releases/tag/v0.86 Diff: https://github.com/rxhanson/Rectangle/compare/v0.85...v0.86 --- pkgs/by-name/re/rectangle/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/re/rectangle/package.nix b/pkgs/by-name/re/rectangle/package.nix index a2a2f9bfd991..6d3d9e5493ad 100644 --- a/pkgs/by-name/re/rectangle/package.nix +++ b/pkgs/by-name/re/rectangle/package.nix @@ -8,11 +8,11 @@ stdenvNoCC.mkDerivation (finalAttrs: { pname = "rectangle"; - version = "0.85"; + version = "0.86"; src = fetchurl { url = "https://github.com/rxhanson/Rectangle/releases/download/v${finalAttrs.version}/Rectangle${finalAttrs.version}.dmg"; - hash = "sha256-TBUC5z2BZMt0eb9NAD3/y9y23iRzs7YRJSfyb3QN1Mc="; + hash = "sha256-UUL5xaZn+NDQ5VvlVH9ROek5AFQ5fyZLGubLc/qQqcI="; }; sourceRoot = ".";