From 6785dae7483bfd5ef3596ddee74726fa541cb850 Mon Sep 17 00:00:00 2001 From: Thiago Kenji Okada Date: Wed, 16 Nov 2022 20:07:23 +0000 Subject: [PATCH 1/2] nixos/picom: remove experimentalBackends option Removed by upstream in the recent v10 release. --- nixos/modules/services/x11/picom.nix | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/nixos/modules/services/x11/picom.nix b/nixos/modules/services/x11/picom.nix index d42cf1d7412f..56b55709e47f 100644 --- a/nixos/modules/services/x11/picom.nix +++ b/nixos/modules/services/x11/picom.nix @@ -47,6 +47,9 @@ in { since picom v6 and was subsequently removed by upstream. See https://github.com/yshui/picom/commit/bcbc410 '') + (mkRemovedOptionModule [ "services" "picom" "experimentalBackends" ] '' + This option was removed by upstream since picom v10. + '') ]; options.services.picom = { @@ -58,14 +61,6 @@ in { ''; }; - experimentalBackends = mkOption { - type = types.bool; - default = false; - description = lib.mdDoc '' - Whether to use the unstable new reimplementation of the backends. - ''; - }; - fade = mkOption { type = types.bool; default = false; @@ -306,8 +301,7 @@ in { }; serviceConfig = { - ExecStart = "${pkgs.picom}/bin/picom --config ${configFile}" - + (optionalString cfg.experimentalBackends " --experimental-backends"); + ExecStart = "${pkgs.picom}/bin/picom --config ${configFile}"; RestartSec = 3; Restart = "always"; }; From eb8b2d71428eb6ad5c7b9a56fe28b01ce434894c Mon Sep 17 00:00:00 2001 From: Thiago Kenji Okada Date: Wed, 16 Nov 2022 20:12:28 +0000 Subject: [PATCH 2/2] nixos/docs: document picom module changes --- .../doc/manual/from_md/release-notes/rl-2211.section.xml | 8 ++++++++ nixos/doc/manual/release-notes/rl-2211.section.md | 2 ++ 2 files changed, 10 insertions(+) diff --git a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml index 100ce3b1a2f2..1c5af094f446 100644 --- a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml +++ b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml @@ -1464,6 +1464,14 @@ services.github-runner.serviceOverrides.SupplementaryGroups = [ are under programs.firefox. + + + The option + services.picom.experimentalBackends was + removed since it is now the default and the option will cause + picom to quit instead. + + diff --git a/nixos/doc/manual/release-notes/rl-2211.section.md b/nixos/doc/manual/release-notes/rl-2211.section.md index a69c35acf45e..0fdd9277a8c5 100644 --- a/nixos/doc/manual/release-notes/rl-2211.section.md +++ b/nixos/doc/manual/release-notes/rl-2211.section.md @@ -447,4 +447,6 @@ Available as [services.patroni](options.html#opt-services.patroni.enable). - A NixOS module for Firefox has been added which allows preferences and [policies](https://github.com/mozilla/policy-templates/blob/master/README.md) to be set. This also allows extensions to be installed via the `ExtensionSettings` policy. The new options are under `programs.firefox`. +- The option `services.picom.experimentalBackends` was removed since it is now the default and the option will cause `picom` to quit instead. +