From cfeaf14c52585eaa8125defa8482cd2f7198d9bd Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sat, 14 Jun 2025 11:07:12 +0200 Subject: [PATCH] nodejs*: skip some flaky tests --- pkgs/development/web/nodejs/nodejs.nix | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix index 873a333e5f38..0ec9e4ec9633 100644 --- a/pkgs/development/web/nodejs/nodejs.nix +++ b/pkgs/development/web/nodejs/nodejs.nix @@ -428,6 +428,9 @@ let "test-debugger-random-port-with-inspect-port" "test-debugger-launch" "test-debugger-pid" + + # Those are annoyingly flaky, but not enough to be marked as such upstream. + "test-wasi" ] ++ lib.optionals (stdenv.buildPlatform.isDarwin && stdenv.buildPlatform.isx86_64) [ # These tests fail on x86_64-darwin (even without sandbox). @@ -435,10 +438,13 @@ let "test-fs-readv" "test-fs-readv-sync" "test-vm-memleak" + + # Those are annoyingly flaky, but not enough to be marked as such upstream. + "test-tick-processor-arguments" + "test-set-raw-mode-reset-signal" ] - ++ lib.optional ( - stdenv.buildPlatform.isDarwin && stdenv.buildPlatform.isx86_64 && majorVersion == "20" - ) "test-tick-processor-arguments" # flaky + # Those are annoyingly flaky, but not enough to be marked as such upstream. + ++ lib.optional (majorVersion == "22") "test-child-process-stdout-flush-exit" ) }" ];