From cf5966c180532dea44598cf2ada23a6bb0cf950a Mon Sep 17 00:00:00 2001 From: Konstantin Alekseev Date: Sun, 8 Mar 2026 16:12:13 +0200 Subject: [PATCH] playwright: move update script into core package --- .../development/python-modules/playwright/default.nix | 3 +-- pkgs/development/web/playwright/driver.nix | 1 + .../{python-modules => web}/playwright/update.sh | 11 +++++------ 3 files changed, 7 insertions(+), 8 deletions(-) rename pkgs/development/{python-modules => web}/playwright/update.sh (93%) diff --git a/pkgs/development/python-modules/playwright/default.nix b/pkgs/development/python-modules/playwright/default.nix index 968a85782e52..e1e19a40643b 100644 --- a/pkgs/development/python-modules/playwright/default.nix +++ b/pkgs/development/python-modules/playwright/default.nix @@ -19,7 +19,7 @@ let in buildPythonPackage rec { pname = "playwright"; - # run ./pkgs/development/python-modules/playwright/update.sh to update + # run ./pkgs/development/web/playwright/update.sh to update version = "1.57.0"; pyproject = true; @@ -97,7 +97,6 @@ buildPythonPackage rec { # Package and playwright driver versions are tightly coupled. # Use the update script to ensure synchronized updates. skipBulkUpdate = true; - updateScript = ./update.sh; }; meta = { diff --git a/pkgs/development/web/playwright/driver.nix b/pkgs/development/web/playwright/driver.nix index 7750fac295ca..32aa37f39449 100644 --- a/pkgs/development/web/playwright/driver.nix +++ b/pkgs/development/web/playwright/driver.nix @@ -173,6 +173,7 @@ let withChromiumHeadlessShell = false; }; inherit components; + updateScript = ./update.sh; }; }); diff --git a/pkgs/development/python-modules/playwright/update.sh b/pkgs/development/web/playwright/update.sh similarity index 93% rename from pkgs/development/python-modules/playwright/update.sh rename to pkgs/development/web/playwright/update.sh index cdd80a84c691..4534aea5d6c3 100755 --- a/pkgs/development/python-modules/playwright/update.sh +++ b/pkgs/development/web/playwright/update.sh @@ -15,8 +15,7 @@ driver_version=$(curl -Ls "$setup_py_url" | grep '^driver_version =' | grep -Eo update-source-version playwright-driver "$driver_version" update-source-version python3Packages.playwright "$version" -playwright_dir="$root/../../web/playwright" -driver_file="$playwright_dir/driver.nix" +driver_file="$root/driver.nix" repo_url_prefix="https://github.com/microsoft/playwright/raw" temp_dir=$(mktemp -d) @@ -78,10 +77,10 @@ update_browser() { buildname="$name" fi - revision="$(jq -r ".browsers[\"$buildname\"].revision" "$playwright_dir/browsers.json")" - replace_sha "$playwright_dir/$name.nix" "x86_64-$platform" \ + revision="$(jq -r ".browsers[\"$buildname\"].revision" "$root/browsers.json")" + replace_sha "$root/$name.nix" "x86_64-$platform" \ "$(prefetch_browser "https://playwright.azureedge.net/builds/$buildname/$revision/$name-$suffix.zip" $stripRoot)" - replace_sha "$playwright_dir/$name.nix" "aarch64-$platform" \ + replace_sha "$root/$name.nix" "aarch64-$platform" \ "$(prefetch_browser "https://playwright.azureedge.net/builds/$buildname/$revision/$name-$aarch64_suffix.zip" $stripRoot)" } @@ -95,7 +94,7 @@ curl -fsSl \ | map({(.name): . | del(.name)}) | add ) - ' > "$playwright_dir/browsers.json" + ' > "$root/browsers.json" update_browser "chromium" "linux" update_browser "chromium-headless-shell" "linux"