From cc52eff6c61d69441d4df0bbdac237346deac968 Mon Sep 17 00:00:00 2001 From: Nikolay Amiantov Date: Fri, 23 Feb 2018 18:47:43 +0300 Subject: [PATCH] Revert "cups service: fix client sockets" This reverts commit cf4c07734364e7e59414f486381360b42a9f88ea. --- nixos/modules/services/printing/cupsd.nix | 7 ++----- nixos/tests/printing.nix | 4 +--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/nixos/modules/services/printing/cupsd.nix b/nixos/modules/services/printing/cupsd.nix index ecab8cfc7df9..4c7f58d1d8bc 100644 --- a/nixos/modules/services/printing/cupsd.nix +++ b/nixos/modules/services/printing/cupsd.nix @@ -124,7 +124,7 @@ in listenAddresses = mkOption { type = types.listOf types.str; - default = [ "localhost:631" ]; + default = [ "127.0.0.1:631" ]; example = [ "*:631" ]; description = '' A list of addresses and ports on which to listen. @@ -321,10 +321,7 @@ in ''} ''; - serviceConfig = { - PrivateTmp = true; - RuntimeDirectory = [ "cups" ]; - }; + serviceConfig.PrivateTmp = true; }; systemd.services.cups-browsed = mkIf avahiEnabled diff --git a/nixos/tests/printing.nix b/nixos/tests/printing.nix index 989008830613..2d3ecaf94cfa 100644 --- a/nixos/tests/printing.nix +++ b/nixos/tests/printing.nix @@ -39,9 +39,7 @@ import ./make-test.nix ({pkgs, ... }: { $client->waitForUnit("cups.service"); $client->sleep(10); # wait until cups is fully initialized $client->succeed("lpstat -r") =~ /scheduler is running/ or die; - # Test that UNIX socket is used for connections. - $client->succeed("lpstat -H") =~ "/var/run/cups/cups.sock" or die; - # Test that HTTP server is available too. + $client->succeed("lpstat -H") =~ "localhost:631" or die; $client->succeed("curl --fail http://localhost:631/"); $client->succeed("curl --fail http://server:631/"); $server->fail("curl --fail --connect-timeout 2 http://client:631/");