From cbc5c8ff44a4d0818ec0aecf4de93ac441dd0c56 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Mon, 2 Jun 2025 12:23:58 +0200 Subject: [PATCH] gst_all_1: move plugin pc files to $dev The multiple-outputs hook doesn't know to handle pkg-config files in subdirectories like these. Fixing this resolves a reference cycle that caused building under pkgsStatic to fail. --- pkgs/development/libraries/gstreamer/bad/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/base/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/core/default.nix | 1 + pkgs/development/libraries/gstreamer/devtools/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/ges/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/good/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/libav/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/rtsp-server/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/ugly/default.nix | 4 ++++ pkgs/development/libraries/gstreamer/vaapi/default.nix | 4 ++++ 10 files changed, 37 insertions(+) diff --git a/pkgs/development/libraries/gstreamer/bad/default.nix b/pkgs/development/libraries/gstreamer/bad/default.nix index f2330c8cf20f..80573843063d 100644 --- a/pkgs/development/libraries/gstreamer/bad/default.nix +++ b/pkgs/development/libraries/gstreamer/bad/default.nix @@ -399,6 +399,10 @@ stdenv.mkDerivation (finalAttrs: { doCheck = false; # fails 20 out of 58 tests, expensive + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { tests = { full = gst-plugins-bad.override { diff --git a/pkgs/development/libraries/gstreamer/base/default.nix b/pkgs/development/libraries/gstreamer/base/default.nix index 4a9c8c4e75f3..db8b65fc1dae 100644 --- a/pkgs/development/libraries/gstreamer/base/default.nix +++ b/pkgs/development/libraries/gstreamer/base/default.nix @@ -170,6 +170,10 @@ stdenv.mkDerivation (finalAttrs: { doCheck = false; # fails, wants DRI access for OpenGL + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { # Downstream `gst-*` packages depending on `gst-plugins-base` # have meson build options like 'gl' etc. that depend diff --git a/pkgs/development/libraries/gstreamer/core/default.nix b/pkgs/development/libraries/gstreamer/core/default.nix index 73f3badbbdd8..5179b6e5d5e5 100644 --- a/pkgs/development/libraries/gstreamer/core/default.nix +++ b/pkgs/development/libraries/gstreamer/core/default.nix @@ -134,6 +134,7 @@ stdenv.mkDerivation (finalAttrs: { ''; preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" moveToOutput "share/bash-completion" "$bin" ''; diff --git a/pkgs/development/libraries/gstreamer/devtools/default.nix b/pkgs/development/libraries/gstreamer/devtools/default.nix index e92607625e9f..080760f4ed23 100644 --- a/pkgs/development/libraries/gstreamer/devtools/default.nix +++ b/pkgs/development/libraries/gstreamer/devtools/default.nix @@ -127,6 +127,10 @@ stdenv.mkDerivation (finalAttrs: { ]; }; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + meta = { description = "Integration testing infrastructure for the GStreamer framework"; homepage = "https://gstreamer.freedesktop.org"; diff --git a/pkgs/development/libraries/gstreamer/ges/default.nix b/pkgs/development/libraries/gstreamer/ges/default.nix index 60cabc07f942..99ffb34f8b64 100644 --- a/pkgs/development/libraries/gstreamer/ges/default.nix +++ b/pkgs/development/libraries/gstreamer/ges/default.nix @@ -73,6 +73,10 @@ stdenv.mkDerivation (finalAttrs: { scripts/extract-release-date-from-doap-file.py ''; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { updateScript = directoryListingUpdater { }; }; diff --git a/pkgs/development/libraries/gstreamer/good/default.nix b/pkgs/development/libraries/gstreamer/good/default.nix index 1089c7e8a9cc..27c7e3b32ee2 100644 --- a/pkgs/development/libraries/gstreamer/good/default.nix +++ b/pkgs/development/libraries/gstreamer/good/default.nix @@ -262,6 +262,10 @@ stdenv.mkDerivation (finalAttrs: { # must be explicitly set since 5590e365 dontWrapQtApps = true; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { tests = { gtk = gst-plugins-good.override { diff --git a/pkgs/development/libraries/gstreamer/libav/default.nix b/pkgs/development/libraries/gstreamer/libav/default.nix index 990ed19d1b7b..66573381c184 100644 --- a/pkgs/development/libraries/gstreamer/libav/default.nix +++ b/pkgs/development/libraries/gstreamer/libav/default.nix @@ -60,6 +60,10 @@ stdenv.mkDerivation (finalAttrs: { scripts/extract-release-date-from-doap-file.py ''; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { updateScript = directoryListingUpdater { }; }; diff --git a/pkgs/development/libraries/gstreamer/rtsp-server/default.nix b/pkgs/development/libraries/gstreamer/rtsp-server/default.nix index 61dfb7b58037..1fbc9f19cd2a 100644 --- a/pkgs/development/libraries/gstreamer/rtsp-server/default.nix +++ b/pkgs/development/libraries/gstreamer/rtsp-server/default.nix @@ -62,6 +62,10 @@ stdenv.mkDerivation (finalAttrs: { scripts/extract-release-date-from-doap-file.py ''; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { updateScript = directoryListingUpdater { }; }; diff --git a/pkgs/development/libraries/gstreamer/ugly/default.nix b/pkgs/development/libraries/gstreamer/ugly/default.nix index 91ed20d57dda..d3670fa88cc1 100644 --- a/pkgs/development/libraries/gstreamer/ugly/default.nix +++ b/pkgs/development/libraries/gstreamer/ugly/default.nix @@ -93,6 +93,10 @@ stdenv.mkDerivation (finalAttrs: { scripts/extract-release-date-from-doap-file.py ''; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { tests = { lgplOnly = gst-plugins-ugly.override { diff --git a/pkgs/development/libraries/gstreamer/vaapi/default.nix b/pkgs/development/libraries/gstreamer/vaapi/default.nix index 4f19e307addd..e40b0164f474 100644 --- a/pkgs/development/libraries/gstreamer/vaapi/default.nix +++ b/pkgs/development/libraries/gstreamer/vaapi/default.nix @@ -93,6 +93,10 @@ stdenv.mkDerivation (finalAttrs: { scripts/extract-release-date-from-doap-file.py ''; + preFixup = '' + moveToOutput "lib/gstreamer-1.0/pkgconfig" "$dev" + ''; + passthru = { updateScript = directoryListingUpdater { }; };