From f16b695b987debbb70f7007ce1ca42b0f8cf685d Mon Sep 17 00:00:00 2001 From: Yarny0 <41838844+Yarny0@users.noreply.github.com> Date: Sun, 15 Jun 2025 08:34:43 +0200 Subject: [PATCH 1/2] smplayer: fix hash after upstream replaced their git tag Our smplayer package received a normal update with commit https://github.com/NixOS/nixpkgs/commit/8d99101d35fdfbbff0465dd899334321eee61363 . After that commit and a corresponding pull request got created with https://github.com/NixOS/nixpkgs/pull/415020 , upstream apparently added a new commit https://github.com/smplayer-dev/smplayer/commit/b62faa90efb6c6be8e0938a42e70fbfb3916feb6 to their repository, and replaced the git tag (release tag) https://github.com/smplayer-dev/smplayer/releases/tag/v25.6.0 . This tag previously pointed to https://github.com/smplayer-dev/smplayer/commit/4a27de33a4cab71215002f138daab1e3c69ca7ef for which the old nixpkgs hash is valid. Due to the invalidation of the old git tag, we have to adapt our source hash. --- pkgs/by-name/sm/smplayer/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/sm/smplayer/package.nix b/pkgs/by-name/sm/smplayer/package.nix index 8df2beda185c..437f21ab0239 100644 --- a/pkgs/by-name/sm/smplayer/package.nix +++ b/pkgs/by-name/sm/smplayer/package.nix @@ -16,7 +16,7 @@ stdenv.mkDerivation (finalAttrs: { owner = "smplayer-dev"; repo = "smplayer"; rev = "v${finalAttrs.version}"; - hash = "sha256-dyUT8PdvsFZsEZQNSsC2TQd90KOrY9FIb9Do+JKdUHs="; + hash = "sha256-txGz6v9hkvnrmVmBHsi1B2eC/iNT1tg4dU5AcMsSCic="; }; nativeBuildInputs = [ From 3420cab114a9c49a792b7103c3c1bcee7d64b0bc Mon Sep 17 00:00:00 2001 From: Yarny0 <41838844+Yarny0@users.noreply.github.com> Date: Sun, 15 Jun 2025 08:46:37 +0200 Subject: [PATCH 2/2] smplayer: fetchFromGitHub: rev -> tag Inspired by https://github.com/NixOS/nixpkgs/commit/cb9f9a1e5a51a87d59b373db7016cee1608debd5 --- pkgs/by-name/sm/smplayer/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sm/smplayer/package.nix b/pkgs/by-name/sm/smplayer/package.nix index 437f21ab0239..6c4489332716 100644 --- a/pkgs/by-name/sm/smplayer/package.nix +++ b/pkgs/by-name/sm/smplayer/package.nix @@ -15,7 +15,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "smplayer-dev"; repo = "smplayer"; - rev = "v${finalAttrs.version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-txGz6v9hkvnrmVmBHsi1B2eC/iNT1tg4dU5AcMsSCic="; }; @@ -51,7 +51,7 @@ stdenv.mkDerivation (finalAttrs: { options of MPlayer, SMPlayer adds other interesting features like the possibility to play Youtube videos or download subtitles. ''; - changelog = "https://github.com/smplayer-dev/smplayer/releases/tag/${finalAttrs.src.rev}"; + changelog = "https://github.com/smplayer-dev/smplayer/releases/tag/${finalAttrs.src.tag}"; license = lib.licenses.gpl3Plus; maintainers = with lib.maintainers; [ ]; platforms = lib.platforms.linux;