diff --git a/nixos/doc/manual/release-notes/rl-2411.section.md b/nixos/doc/manual/release-notes/rl-2411.section.md index 1b0c29f3809f..929017a5e550 100644 --- a/nixos/doc/manual/release-notes/rl-2411.section.md +++ b/nixos/doc/manual/release-notes/rl-2411.section.md @@ -720,6 +720,8 @@ This saves UPS battery and ensures that host(s) get back up again when power comes back, even in the scenario when the UPS would have had enough capacity to keep power on during the whole power outage. If you like the old behaviour of keeping the UPSs on (and emptying the battery) after the host(s) have shut down, and risk not getting a power cycle event to get the host(s) back up, set `power.ups.upsmon.settings.POWERDOWNFLAG = null;`. +- `nixos-firewall-tool` now supports nftables in addition to iptables and is installed by default when NixOS firewall is enabled. + - Support for *runner registration tokens* has been [deprecated](https://gitlab.com/gitlab-org/gitlab/-/issues/380872) in `gitlab-runner` 15.6 and is expected to be removed in `gitlab-runner` 18.0. Configuration of existing runners should be changed to using *runner authentication tokens* by configuring diff --git a/nixos/modules/services/networking/firewall-iptables.nix b/nixos/modules/services/networking/firewall-iptables.nix index e4fa7676fd07..086106f0d8d2 100644 --- a/nixos/modules/services/networking/firewall-iptables.nix +++ b/nixos/modules/services/networking/firewall-iptables.nix @@ -297,7 +297,6 @@ in } ]; - environment.systemPackages = [ pkgs.nixos-firewall-tool ]; networking.firewall.checkReversePath = lib.mkIf (!kernelHasRPFilter) (lib.mkDefault false); systemd.services.firewall = { diff --git a/nixos/modules/services/networking/firewall-nftables.nix b/nixos/modules/services/networking/firewall-nftables.nix index f954a5284103..06f070caf25a 100644 --- a/nixos/modules/services/networking/firewall-nftables.nix +++ b/nixos/modules/services/networking/firewall-nftables.nix @@ -81,6 +81,13 @@ in networking.nftables.tables."nixos-fw".family = "inet"; networking.nftables.tables."nixos-fw".content = '' + set temp-ports { + comment "Temporarily opened ports" + type inet_proto . inet_service + flags interval + auto-merge + } + ${lib.optionalString (cfg.checkReversePath != false) '' chain rpfilter { type filter hook prerouting priority mangle + 10; policy drop; @@ -147,6 +154,8 @@ in '' ) cfg.allInterfaces)} + meta l4proto . th dport @temp-ports accept + ${lib.optionalString cfg.allowPing '' icmp type echo-request ${lib.optionalString (cfg.pingLimit != null) "limit rate ${cfg.pingLimit}"} accept comment "allow ping" ''} diff --git a/nixos/modules/services/networking/firewall.nix b/nixos/modules/services/networking/firewall.nix index 27e17c464ba9..ab575b884a71 100644 --- a/nixos/modules/services/networking/firewall.nix +++ b/nixos/modules/services/networking/firewall.nix @@ -274,7 +274,10 @@ in networking.firewall.trustedInterfaces = [ "lo" ]; - environment.systemPackages = [ cfg.package ] ++ cfg.extraPackages; + environment.systemPackages = [ + cfg.package + pkgs.nixos-firewall-tool + ] ++ cfg.extraPackages; boot.kernelModules = (lib.optional cfg.autoLoadConntrackHelpers "nf_conntrack") ++ map (x: "nf_conntrack_${x}") cfg.connectionTrackingModules; diff --git a/pkgs/by-name/ni/nixos-firewall-tool/nixos-firewall-tool.sh b/pkgs/by-name/ni/nixos-firewall-tool/nixos-firewall-tool.sh index 17e7ce8a724c..6870277736e7 100755 --- a/pkgs/by-name/ni/nixos-firewall-tool/nixos-firewall-tool.sh +++ b/pkgs/by-name/ni/nixos-firewall-tool/nixos-firewall-tool.sh @@ -2,10 +2,19 @@ set -euo pipefail +# Detect if iptables or nftables-based firewall is used. +if [[ -e /etc/systemd/system/firewall.service ]]; then + BACKEND=iptables +elif [[ -e /etc/systemd/system/nftables.service ]]; then + BACKEND=nftables +else + echo "nixos-firewall-tool: cannot detect firewall backend" >&2 + exit 1 +fi + ip46tables() { iptables -w "$@" ip6tables -w "$@" - } show_help() { @@ -36,13 +45,34 @@ case $1 in protocol="$2" port="$3" - ip46tables -I nixos-fw -p "$protocol" --dport "$port" -j nixos-fw-accept + case $BACKEND in + iptables) + ip46tables -I nixos-fw -p "$protocol" --dport "$port" -j nixos-fw-accept + ;; + nftables) + nft add element inet nixos-fw "temp-ports" "{ $protocol . $port }" + ;; + esac ;; "show") - ip46tables --numeric --list nixos-fw + case $BACKEND in + iptables) + ip46tables --numeric --list nixos-fw + ;; + nftables) + nft list table inet nixos-fw + ;; + esac ;; "reset") - systemctl restart firewall.service + case $BACKEND in + iptables) + systemctl restart firewall.service + ;; + nftables) + nft flush set inet nixos-fw "temp-ports" + ;; + esac ;; -h|--help|help) show_help diff --git a/pkgs/by-name/ni/nixos-firewall-tool/package.nix b/pkgs/by-name/ni/nixos-firewall-tool/package.nix index 78af5cb8d571..b5db51082266 100644 --- a/pkgs/by-name/ni/nixos-firewall-tool/package.nix +++ b/pkgs/by-name/ni/nixos-firewall-tool/package.nix @@ -1,15 +1,13 @@ -{ writeShellApplication, iptables, lib }: +{ writeShellApplication, lib }: writeShellApplication { name = "nixos-firewall-tool"; + text = builtins.readFile ./nixos-firewall-tool.sh; - runtimeInputs = [ - iptables - ]; meta = with lib; { description = "Temporarily manipulate the NixOS firewall"; license = licenses.mit; - maintainers = with maintainers; [ clerie ]; + maintainers = with maintainers; [ clerie rvfg garyguo ]; }; }