From 971abff5d5bed01e4e5f574282390c52f7b94aff Mon Sep 17 00:00:00 2001 From: Vincent Laporte Date: Tue, 18 Apr 2023 11:23:55 +0200 Subject: [PATCH 1/2] =?UTF-8?q?ocamlPackages.async=5Fssl:=C2=A0remove=20br?= =?UTF-8?q?oken?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pkgs/development/ocaml-modules/conduit/async.nix | 2 +- pkgs/development/ocaml-modules/janestreet/0.12.nix | 12 ------------ .../development/ocaml-modules/janestreet/default.nix | 12 ------------ 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/pkgs/development/ocaml-modules/conduit/async.nix b/pkgs/development/ocaml-modules/conduit/async.nix index a110e6dc1677..249635d14bb8 100644 --- a/pkgs/development/ocaml-modules/conduit/async.nix +++ b/pkgs/development/ocaml-modules/conduit/async.nix @@ -1,4 +1,4 @@ -{ lib, buildDunePackage, async, async_ssl, ppx_sexp_conv, ppx_here, uri, conduit +{ lib, buildDunePackage, async, async_ssl ? null, ppx_sexp_conv, ppx_here, uri, conduit , core, ipaddr, ipaddr-sexp, sexplib }: diff --git a/pkgs/development/ocaml-modules/janestreet/0.12.nix b/pkgs/development/ocaml-modules/janestreet/0.12.nix index c3b4b0c6d705..8d7943af42b6 100644 --- a/pkgs/development/ocaml-modules/janestreet/0.12.nix +++ b/pkgs/development/ocaml-modules/janestreet/0.12.nix @@ -377,18 +377,6 @@ with self; propagatedBuildInputs = [ async_extra textutils ]; }; - async_ssl = janePackage { - pname = "async_ssl"; - hash = "02ard8x5q5c42d9jdqmyzfx624yjq8cxxmvq3zb82hf6p8cc57ml"; - meta = { - description = "An Async-pipe-based interface with OpenSSL"; - # ctypes no longer works with dune 1 - # dune 2 no longer supports jbuild - broken = true; - }; - propagatedBuildInputs = [ async ctypes openssl ]; - }; - async_find = janePackage { pname = "async_find"; hash = "0qsz9f15s5rlk6za10s810v6nlkdxg2g9p1827lcpa7nhjcpi673"; diff --git a/pkgs/development/ocaml-modules/janestreet/default.nix b/pkgs/development/ocaml-modules/janestreet/default.nix index ee906a722501..b0ab637bfba3 100644 --- a/pkgs/development/ocaml-modules/janestreet/default.nix +++ b/pkgs/development/ocaml-modules/janestreet/default.nix @@ -413,18 +413,6 @@ with self; meta.description = "Shell helpers for Async"; }; - async_ssl = janePackage { - pname = "async_ssl"; - hash = "1p83fzfla4rb820irdrz3f2hp8kq5zrhw47rqmfv6qydlca1bq64"; - propagatedBuildInputs = [ async ctypes openssl ]; - meta = { - description = "Async wrappers for SSL"; - # ctypes no longer works with dune 1 - # dune 2 no longer supports jbuild - broken = true; - }; - }; - sexp_pretty = janePackage { pname = "sexp_pretty"; hash = "0xskahjggbwvvb82fn0jp1didxbgpmgks76xhwp9s3vqkhgz6918"; From c987ccb045a5d9f6171e02e2e41182f09023612a Mon Sep 17 00:00:00 2001 From: Vincent Laporte Date: Tue, 18 Apr 2023 11:25:39 +0200 Subject: [PATCH 2/2] ocamlPackages.janeStreet: pin Dune to version 1 for OCaml < 4.08 --- pkgs/development/ocaml-modules/janestreet/janePackage.nix | 2 +- pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/ocaml-modules/janestreet/janePackage.nix b/pkgs/development/ocaml-modules/janestreet/janePackage.nix index 9552268abc2e..f4cef99046ad 100644 --- a/pkgs/development/ocaml-modules/janestreet/janePackage.nix +++ b/pkgs/development/ocaml-modules/janestreet/janePackage.nix @@ -5,7 +5,7 @@ buildDunePackage (args // { inherit version buildInputs; - useDune2 = false; + duneVersion = "1"; minimalOCamlVersion = "4.04"; diff --git a/pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix b/pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix index d61f1b6d41c2..5ab455ddff3e 100644 --- a/pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix +++ b/pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix @@ -5,7 +5,7 @@ buildDunePackage (args // { inherit version; - useDune2 = false; + duneVersion = "1"; minimalOCamlVersion = "4.07";