From 6e4d676341e0adbf1a396d8c0698b99b7901cffc Mon Sep 17 00:00:00 2001 From: Alex James Date: Mon, 1 Sep 2025 14:50:07 -0500 Subject: [PATCH 1/2] mkvtoolnix: drop unused dependencies from buildInputs - expat was replaced with pugixml for XML parsing in 5.5.0 [1] - libmagic was replaced with Qt for MIME type detection in 59.0.0 [2] - xdg-utils does not appear to be used by MKVToolNix itself, though /usr/bin/xdg-open is listed as an example command for the "Execute a program" option in the MKVToolnixGUI preferences. [1]: https://codeberg.org/mbunkus/mkvtoolnix/src/branch/main/NEWS.md#other-changes-29 [2]: https://codeberg.org/mbunkus/mkvtoolnix/src/branch/main/NEWS.md#version-59-0-0-shining-star-2021-07-10 --- pkgs/by-name/mk/mkvtoolnix/package.nix | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkgs/by-name/mk/mkvtoolnix/package.nix b/pkgs/by-name/mk/mkvtoolnix/package.nix index 7d320d5e78fe..c911a7d90e98 100644 --- a/pkgs/by-name/mk/mkvtoolnix/package.nix +++ b/pkgs/by-name/mk/mkvtoolnix/package.nix @@ -8,8 +8,6 @@ boost, cmark, docbook_xsl, - expat, - file, flac, fmt, gettext, @@ -26,7 +24,6 @@ pugixml, qt6, utf8cpp, - xdg-utils, zlib, nix-update-script, withGUI ? true, @@ -81,8 +78,6 @@ stdenv.mkDerivation (finalAttrs: { # qtbase and qtmultimedia are needed without the GUI buildInputs = [ boost - expat - file flac fmt gmp @@ -96,7 +91,6 @@ stdenv.mkDerivation (finalAttrs: { qt6.qtbase qt6.qtmultimedia utf8cpp - xdg-utils zlib ] ++ optionals withGUI [ cmark ] From 653b1e12250ad2f4298f70be9abd65209f0dbed2 Mon Sep 17 00:00:00 2001 From: Alex James Date: Sat, 23 May 2026 21:15:55 -0700 Subject: [PATCH 2/2] mkvtoolnix: use structuredAttrs --- pkgs/by-name/mk/mkvtoolnix/package.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/by-name/mk/mkvtoolnix/package.nix b/pkgs/by-name/mk/mkvtoolnix/package.nix index c911a7d90e98..ead5f5734f45 100644 --- a/pkgs/by-name/mk/mkvtoolnix/package.nix +++ b/pkgs/by-name/mk/mkvtoolnix/package.nix @@ -64,6 +64,8 @@ stdenv.mkDerivation (finalAttrs: { }; }; + __structuredAttrs = true; + nativeBuildInputs = [ autoreconfHook docbook_xsl