From 6a12ab0c22e87f845306158e3042445f35e1330c Mon Sep 17 00:00:00 2001 From: K900 Date: Fri, 31 Jan 2025 19:56:27 +0300 Subject: [PATCH 1/2] separateDebugInfo: don't create broken symlinks --- pkgs/build-support/setup-hooks/separate-debug-info.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkgs/build-support/setup-hooks/separate-debug-info.sh b/pkgs/build-support/setup-hooks/separate-debug-info.sh index ebc773a49218..9cec77b9b0cd 100644 --- a/pkgs/build-support/setup-hooks/separate-debug-info.sh +++ b/pkgs/build-support/setup-hooks/separate-debug-info.sh @@ -43,10 +43,11 @@ _separateDebugInfo() { then echo "separate-debug-info: warning: multiple files with build id $id found, overwriting" fi - $OBJCOPY --only-keep-debug "$i" "$dst/${id:0:2}/${id:2}.debug" - - # Also a create a symlink .debug. - ln -sfn ".build-id/${id:0:2}/${id:2}.debug" "$dst/../$(basename "$i")" + ( + $OBJCOPY --only-keep-debug "$i" "$dst/${id:0:2}/${id:2}.debug" && + # Also a create a symlink .debug. + ln -sfn ".build-id/${id:0:2}/${id:2}.debug" "$dst/../$(basename "$i")" + ) ) || rmdir -p "$dst/${id:0:2}" done < <(find "$prefix" -type f -print0 | sort -z) } From 25f794db5887e7edf40afc3b1f0593d3d7de4ef8 Mon Sep 17 00:00:00 2001 From: K900 Date: Sat, 1 Feb 2025 15:19:29 +0300 Subject: [PATCH 2/2] Revert "qemu: remove broken symlink" This reverts commit bc002a41809b6621019d673cec1567714aedeb49. Hook is fixed now. --- pkgs/applications/virtualization/qemu/default.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkgs/applications/virtualization/qemu/default.nix b/pkgs/applications/virtualization/qemu/default.nix index 9009bb618acd..63675696b3b3 100644 --- a/pkgs/applications/virtualization/qemu/default.nix +++ b/pkgs/applications/virtualization/qemu/default.nix @@ -226,9 +226,6 @@ stdenv.mkDerivation (finalAttrs: { # injected by the pkgsStatic stdenv # rm -f $out/nix-support/propagated-build-inputs - '' + lib.optionalString finalAttrs.separateDebugInfo '' - # HACK: remove broken symlink created by hook - rm $debug/lib/debug/s390-ccw.img ''; preBuild = "cd build";