From c2a221e0191031f6076fe8c80b16c36ec4e1653f Mon Sep 17 00:00:00 2001 From: Michael Daniels Date: Sat, 11 Oct 2025 13:12:14 -0400 Subject: [PATCH] python3Packages.schemainspect: drop Has transitively been marked broken for at least a full release cycle. Dropping per RFC 180. --- .../python-modules/schemainspect/default.nix | 117 ------------------ pkgs/top-level/python-aliases.nix | 1 + pkgs/top-level/python-packages.nix | 2 - 3 files changed, 1 insertion(+), 119 deletions(-) delete mode 100644 pkgs/development/python-modules/schemainspect/default.nix diff --git a/pkgs/development/python-modules/schemainspect/default.nix b/pkgs/development/python-modules/schemainspect/default.nix deleted file mode 100644 index 7a3c322168f0..000000000000 --- a/pkgs/development/python-modules/schemainspect/default.nix +++ /dev/null @@ -1,117 +0,0 @@ -{ - lib, - buildPythonPackage, - fetchFromGitHub, - fetchpatch, - pythonOlder, - sqlalchemy, - sqlbag, - setuptools, - poetry-core, - pytestCheckHook, - pytest-xdist, - pytest-sugar, - postgresql, - postgresqlTestHook, -}: -buildPythonPackage { - pname = "schemainspect"; - version = "3.1.1663587362"; - format = "pyproject"; - disabled = pythonOlder "3.7"; - - src = fetchFromGitHub { - owner = "djrobstep"; - repo = "schemainspect"; - # no tags on github, version patch number is unix time. - rev = "066262d6fb4668f874925305a0b7dbb3ac866882"; - hash = "sha256-SYpQQhlvexNc/xEgSIk8L8J+Ta+3OZycGLeZGQ6DWzk="; - }; - - patches = [ - # https://github.com/djrobstep/schemainspect/pull/87 - (fetchpatch { - name = "specify_poetry.patch"; - url = "https://github.com/djrobstep/schemainspect/commit/bdcd001ef7798236fe0ff35cef52f34f388bfe68.patch"; - hash = "sha256-/SEmcV9GjjvzfbszeGPkfd2DvYenl7bZyWdC0aI3M4M="; - }) - ]; - - nativeBuildInputs = [ poetry-core ]; - propagatedBuildInputs = [ - setuptools # needed for 'pkg_resources' - sqlalchemy - ]; - - nativeCheckInputs = [ - pytestCheckHook - pytest-xdist - pytest-sugar - - postgresql - postgresqlTestHook - - sqlbag - ]; - - preCheck = '' - export PGUSER="nixbld"; - export postgresqlEnableTCP=1; - ''; - disabledTests = [ - # These all fail with "List argument must consist only of tuples or dictionaries": - # Related issue: https://github.com/djrobstep/schemainspect/issues/88 - "test_can_replace" - "test_collations" - "test_constraints" - "test_dep_order" - "test_enum_deps" - "test_exclusion_constraint" - "test_fk_col_order" - "test_fk_info" - "test_generated_columns" - "test_identity_columns" - "test_indexes" - "test_inherit" - "test_kinds" - "test_lineendings" - "test_long_identifiers" - "test_partitions" - "test_postgres_inspect" - "test_postgres_inspect_excludeschema" - "test_postgres_inspect_sigleschema" - "test_raw_connection" - "test_relationship" - "test_replica_trigger" - "test_rls" - "test_separate_validate" - "test_sequences" - "test_table_dependency_order" - "test_types_and_domains" - "test_view_trigger" - "test_weird_names" - ]; - - pytestFlags = [ - "-x" - "-svv" - ]; - - enabledTestPaths = [ - "tests" - ]; - - pythonImportsCheck = [ "schemainspect" ]; - - postUnpack = '' - # this dir is used to bump the version number, having it here fails the build - rm -r ./source/deploy - ''; - - meta = with lib; { - description = "Schema inspection for PostgreSQL, and potentially others"; - homepage = "https://github.com/djrobstep/schemainspect"; - license = with licenses; [ unlicense ]; - maintainers = with maintainers; [ bpeetz ]; - }; -} diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix index 0521f9bc947b..4eddced45fea 100644 --- a/pkgs/top-level/python-aliases.nix +++ b/pkgs/top-level/python-aliases.nix @@ -761,6 +761,7 @@ mapAliases { sabyenc = throw "sabyenc has been removed, due to no updates since June 2019 and being superseded by sabyenc3"; # added 2025-05-03 sampledata = throw "sampledata has been removed, it was unmaintained since 2017"; # added 2024-07-27 sapi-python-client = kbcstorage; # added 2022-04-20 + schemainspect = throw "schemainspect has been removed because it has transitively been marked broken since May 2024, and is unmaintained upstream."; # Added 2025-10-11 scikitimage = scikit-image; # added 2023-05-14 scikitlearn = scikit-learn; # added 2021-07-21 scikit-optimize = throw "scikit-optimize has been removed because it is abandoned"; # added 2024-09-30 diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index 5f5db002b880..6c7753ea9a20 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -16430,8 +16430,6 @@ self: super: with self; { schema-salad = callPackage ../development/python-modules/schema-salad { }; - schemainspect = callPackage ../development/python-modules/schemainspect { }; - schemdraw = callPackage ../development/python-modules/schemdraw { }; schiene = callPackage ../development/python-modules/schiene { };