From c1ebcc6f384bfc016b551cae30eae3d302e938e7 Mon Sep 17 00:00:00 2001
From: Defelo <mail@defelo.de>
Date: Thu, 16 Jan 2025 01:14:36 +0100
Subject: [PATCH] ytdl-sub: refactor

---
 pkgs/by-name/yt/ytdl-sub/package.nix | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/pkgs/by-name/yt/ytdl-sub/package.nix b/pkgs/by-name/yt/ytdl-sub/package.nix
index 001ec595929d..ab4a81bc9f78 100644
--- a/pkgs/by-name/yt/ytdl-sub/package.nix
+++ b/pkgs/by-name/yt/ytdl-sub/package.nix
@@ -1,23 +1,28 @@
 {
   python3Packages,
-  fetchPypi,
+  fetchFromGitHub,
   ffmpeg,
   lib,
+  versionCheckHook,
+  nix-update-script,
 }:
 python3Packages.buildPythonApplication rec {
   pname = "ytdl-sub";
   version = "2024.12.27";
   pyproject = true;
 
-  src = fetchPypi {
-    inherit version;
-    pname = "ytdl_sub";
-    hash = "sha256-7XZlKGzDLG/MVw198Ii+l29F+Lt53MY5QtHU8k9xJWA=";
+  src = fetchFromGitHub {
+    owner = "jmbannon";
+    repo = "ytdl-sub";
+    tag = version;
+    hash = "sha256-PmkBZl4aUw5Wgr83Nyyv54Rra/rDDm04B9bt6Xl+AzE=";
   };
 
-  pythonRelaxDeps = [
-    "yt-dlp"
-  ];
+  postPatch = ''
+    echo '__pypi_version__ = "${version}"; __local_version__ = "${version}"' > src/ytdl_sub/__init__.py
+  '';
+
+  pythonRelaxDeps = [ "yt-dlp" ];
 
   build-system = with python3Packages; [
     setuptools
@@ -37,6 +42,11 @@ python3Packages.buildPythonApplication rec {
     "--set YTDL_SUB_FFPROBE_PATH ${lib.getExe' ffmpeg "ffprobe"}"
   ];
 
+  nativeCheckInputs = [ versionCheckHook ];
+  versionCheckProgramArg = "--version";
+
+  passthru.updateScript = nix-update-script { };
+
   meta = {
     homepage = "https://github.com/jmbannon/ytdl-sub";
     description = "Lightweight tool to automate downloading and metadata generation with yt-dlp";
@@ -47,6 +57,7 @@ python3Packages.buildPythonApplication rec {
     license = lib.licenses.gpl3Only;
     maintainers = with lib.maintainers; [
       loc
+      defelo
     ];
     mainProgram = "ytdl-sub";
   };