From 1536ddeea961c6ea00fef2d6e1dde020f70bfffd Mon Sep 17 00:00:00 2001 From: Patrick Gehrsitz Date: Fri, 11 Jul 2025 17:18:22 +0200 Subject: [PATCH 1/3] nixos/pihole-ftl: fix openFirewallDHCP ports --- nixos/modules/services/networking/pihole-ftl.nix | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nixos/modules/services/networking/pihole-ftl.nix b/nixos/modules/services/networking/pihole-ftl.nix index bda8ab4fa8c8..f4f46a05b2e4 100644 --- a/nixos/modules/services/networking/pihole-ftl.nix +++ b/nixos/modules/services/networking/pihole-ftl.nix @@ -435,8 +435,7 @@ in networking.firewall = lib.mkMerge [ (mkIf cfg.openFirewallDHCP { - allowedUDPPorts = [ 53 ]; - allowedTCPPorts = [ 53 ]; + allowedUDPPorts = [ 67 ]; }) (mkIf cfg.openFirewallWebserver { From 4883f43d367f6b857333853daa72b7dd062cea8f Mon Sep 17 00:00:00 2001 From: Patrick Gehrsitz Date: Fri, 11 Jul 2025 17:19:58 +0200 Subject: [PATCH 2/3] nixos/pihole-ftl: add openFirewallDNS ports --- nixos/modules/services/networking/pihole-ftl.nix | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/nixos/modules/services/networking/pihole-ftl.nix b/nixos/modules/services/networking/pihole-ftl.nix index f4f46a05b2e4..5a8c361adfeb 100644 --- a/nixos/modules/services/networking/pihole-ftl.nix +++ b/nixos/modules/services/networking/pihole-ftl.nix @@ -56,6 +56,12 @@ in example = "3"; }; + openFirewallDNS = mkOption { + type = types.bool; + default = false; + description = "Open ports in the firewall for pihole-FTL's DNS server."; + }; + openFirewallDHCP = mkOption { type = types.bool; default = false; @@ -434,6 +440,11 @@ in }; networking.firewall = lib.mkMerge [ + (mkIf cfg.openFirewallDNS { + allowedUDPPorts = [ 53 ]; + allowedTCPPorts = [ 53 ]; + }) + (mkIf cfg.openFirewallDHCP { allowedUDPPorts = [ 67 ]; }) From 9da74b34fe245d23e986630efb7e532cfece7d87 Mon Sep 17 00:00:00 2001 From: Patrick Gehrsitz Date: Fri, 11 Jul 2025 17:32:07 +0200 Subject: [PATCH 3/3] nixos/pihole-ftl: add openFirewallDNS to docs example --- nixos/modules/services/networking/pihole-ftl.md | 1 + 1 file changed, 1 insertion(+) diff --git a/nixos/modules/services/networking/pihole-ftl.md b/nixos/modules/services/networking/pihole-ftl.md index 4a1b1f986708..0f79fd6101c4 100644 --- a/nixos/modules/services/networking/pihole-ftl.md +++ b/nixos/modules/services/networking/pihole-ftl.md @@ -22,6 +22,7 @@ Example configuration: { services.pihole-ftl = { enable = true; + openFirewallDNS = true; openFirewallDHCP = true; queryLogDeleter.enable = true; lists = [