diff --git a/pkgs/by-name/ct/ctranslate2/package.nix b/pkgs/by-name/ct/ctranslate2/package.nix index 8484d66f3757..c03e25a739ac 100644 --- a/pkgs/by-name/ct/ctranslate2/package.nix +++ b/pkgs/by-name/ct/ctranslate2/package.nix @@ -24,19 +24,18 @@ }: let - cmakeBool = b: if b then "ON" else "OFF"; stdenv' = if withCUDA then cudaPackages.backendStdenv else stdenv; in -stdenv'.mkDerivation rec { +stdenv'.mkDerivation (finalAttrs: { pname = "ctranslate2"; version = "4.6.0"; src = fetchFromGitHub { owner = "OpenNMT"; repo = "CTranslate2"; - rev = "v${version}"; - hash = "sha256-EM2kunqtxo0BTIzrEomfaRsdav7sx6QEOhjDtjjSoYY="; + tag = "v${finalAttrs.version}"; fetchSubmodules = true; + hash = "sha256-EM2kunqtxo0BTIzrEomfaRsdav7sx6QEOhjDtjjSoYY="; }; nativeBuildInputs = [ @@ -50,15 +49,17 @@ stdenv'.mkDerivation rec { # https://opennmt.net/CTranslate2/installation.html#build-options # https://github.com/OpenNMT/CTranslate2/blob/54810350e662ebdb01ecbf8e4a746f02aeff1dd7/python/tools/prepare_build_environment_linux.sh#L53 # https://github.com/OpenNMT/CTranslate2/blob/59d223abcc7e636c1c2956e62482bc3299cc7766/python/tools/prepare_build_environment_macos.sh#L12 - "-DOPENMP_RUNTIME=COMP" - "-DWITH_CUDA=${cmakeBool withCUDA}" - "-DWITH_CUDNN=${cmakeBool withCuDNN}" - "-DWITH_DNNL=${cmakeBool withOneDNN}" - "-DWITH_OPENBLAS=${cmakeBool withOpenblas}" - "-DWITH_RUY=${cmakeBool withRuy}" - "-DWITH_MKL=${cmakeBool withMkl}" + (lib.cmakeFeature "OPENMP_RUNTIME" "COMP") + (lib.cmakeBool "WITH_CUDA" withCUDA) + (lib.cmakeBool "WITH_CUDNN" withCuDNN) + (lib.cmakeBool "WITH_DNNL" withOneDNN) + (lib.cmakeBool "WITH_OPENBLAS" withOpenblas) + (lib.cmakeBool "WITH_RUY" withRuy) + (lib.cmakeBool "WITH_MKL" withMkl) ] - ++ lib.optional stdenv.hostPlatform.isDarwin "-DWITH_ACCELERATE=ON"; + ++ lib.optionals stdenv.hostPlatform.isDarwin [ + (lib.cmakeBool "WITH_ACCELERATE" true) + ]; buildInputs = lib.optionals withMkl [ @@ -90,16 +91,16 @@ stdenv'.mkDerivation rec { ; }; - meta = with lib; { + meta = { description = "Fast inference engine for Transformer models"; mainProgram = "ct2-translator"; homepage = "https://github.com/OpenNMT/CTranslate2"; - changelog = "https://github.com/OpenNMT/CTranslate2/blob/${src.rev}/CHANGELOG.md"; - license = licenses.mit; - maintainers = with maintainers; [ + changelog = "https://github.com/OpenNMT/CTranslate2/blob/${finalAttrs.src.tag}/CHANGELOG.md"; + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ hexa misuzu ]; broken = !(withCuDNN -> withCUDA); }; -} +})