From d228250dc817157c8dd375a02fe7d00e52625611 Mon Sep 17 00:00:00 2001 From: Jeremy Baxter Date: Sat, 10 Feb 2024 10:12:02 +1300 Subject: [PATCH 1/4] tilix: migrate to pkgs/by-name --- .../tilix/default.nix => by-name/ti/tilix/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{applications/terminal-emulators/tilix/default.nix => by-name/ti/tilix/package.nix} (100%) diff --git a/pkgs/applications/terminal-emulators/tilix/default.nix b/pkgs/by-name/ti/tilix/package.nix similarity index 100% rename from pkgs/applications/terminal-emulators/tilix/default.nix rename to pkgs/by-name/ti/tilix/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 441a1439b1c1..515df157a487 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -3096,8 +3096,6 @@ with pkgs; termonad = callPackage ../applications/terminal-emulators/termonad { }; - tilix = callPackage ../applications/terminal-emulators/tilix { }; - tym = callPackage ../applications/terminal-emulators/tym { }; wayst = callPackage ../applications/terminal-emulators/wayst { }; From cac147d49c4f1e113383ca82e94af011ece1782b Mon Sep 17 00:00:00 2001 From: Jeremy Baxter Date: Sat, 10 Feb 2024 10:12:52 +1300 Subject: [PATCH 2/4] tilix: adopt --- pkgs/by-name/ti/tilix/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/ti/tilix/package.nix b/pkgs/by-name/ti/tilix/package.nix index 65da21cbabc7..df050dfdaddf 100644 --- a/pkgs/by-name/ti/tilix/package.nix +++ b/pkgs/by-name/ti/tilix/package.nix @@ -81,7 +81,7 @@ stdenv.mkDerivation rec { description = "Tiling terminal emulator following the Gnome Human Interface Guidelines"; homepage = "https://gnunn1.github.io/tilix-web"; license = licenses.mpl20; - maintainers = with maintainers; [ midchildan ]; + maintainers = with maintainers; [ midchildan jtbx ]; platforms = platforms.linux; mainProgram = "tilix"; }; From e03b63cdaf4fc6655089116582bebfb8369ff581 Mon Sep 17 00:00:00 2001 From: Jeremy Baxter Date: Sat, 10 Feb 2024 10:14:56 +1300 Subject: [PATCH 3/4] tilix: modernize o use the finalAttrs pattern over the rec expression o use hash over sha256 in the call to fetchFromGitHub o put the stdenv function argument on its own line --- pkgs/by-name/ti/tilix/package.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/ti/tilix/package.nix b/pkgs/by-name/ti/tilix/package.nix index df050dfdaddf..fba1e51a1a33 100644 --- a/pkgs/by-name/ti/tilix/package.nix +++ b/pkgs/by-name/ti/tilix/package.nix @@ -1,4 +1,5 @@ -{ lib, stdenv +{ lib +, stdenv , fetchFromGitHub , meson , ninja @@ -19,15 +20,15 @@ , fetchpatch }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "tilix"; version = "1.9.5"; src = fetchFromGitHub { owner = "gnunn1"; repo = "tilix"; - rev = version; - sha256 = "sha256-sPVL5oYDOmloRVm/nONKkC20vZc907c7ixBF6E2PQ8Y="; + rev = finalAttrs.version; + hash = "sha256-sPVL5oYDOmloRVm/nONKkC20vZc907c7ixBF6E2PQ8Y="; }; # Default upstream else LDC fails to link @@ -85,4 +86,4 @@ stdenv.mkDerivation rec { platforms = platforms.linux; mainProgram = "tilix"; }; -} +}) From 5980c1d8556b6b0cad05fc57784d6a0037d9ebf0 Mon Sep 17 00:00:00 2001 From: Jeremy Baxter Date: Sat, 10 Feb 2024 10:31:27 +1300 Subject: [PATCH 4/4] tilix: 1.9.5 -> 1.9.6 --- pkgs/by-name/ti/tilix/package.nix | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/pkgs/by-name/ti/tilix/package.nix b/pkgs/by-name/ti/tilix/package.nix index fba1e51a1a33..2e0bdad0be8c 100644 --- a/pkgs/by-name/ti/tilix/package.nix +++ b/pkgs/by-name/ti/tilix/package.nix @@ -17,18 +17,17 @@ , libunwind , appstream , nixosTests -, fetchpatch }: stdenv.mkDerivation (finalAttrs: { pname = "tilix"; - version = "1.9.5"; + version = "1.9.6"; src = fetchFromGitHub { owner = "gnunn1"; repo = "tilix"; rev = finalAttrs.version; - hash = "sha256-sPVL5oYDOmloRVm/nONKkC20vZc907c7ixBF6E2PQ8Y="; + hash = "sha256-KP0ojwyZ5FaYKW0nK9mGGAiz1h+gTbfjCUDCgN2LAO8="; }; # Default upstream else LDC fails to link @@ -57,15 +56,6 @@ stdenv.mkDerivation (finalAttrs: { libunwind ]; - patches = [ - # https://github.com/gnunn1/tilix/issues/2151 - (fetchpatch { - name = "tilix-replace-std-xml-with-gmarkup.patch"; - url = "https://github.com/gnunn1/tilix/commit/b02779737997a02b98b690e6f8478d28d5e931a5.patch"; - hash = "sha256-6p+DomJEZ/hCW8RTjttKsTDsgHZ6eFKj/71TU5O/Ysg="; - }) - ]; - postPatch = '' chmod +x meson_post_install.py patchShebangs meson_post_install.py