From 8ac5f6dec055f66d00fdd2561c348970cfe1d48e Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Fri, 15 Aug 2025 14:59:27 -0700 Subject: [PATCH 1/3] python3Packages.google-cloud-storage: build from GitHub --- .../google-cloud-storage/default.nix | 25 +++++++++++-------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/pkgs/development/python-modules/google-cloud-storage/default.nix b/pkgs/development/python-modules/google-cloud-storage/default.nix index 84fa74f9e9e0..314d513b0b59 100644 --- a/pkgs/development/python-modules/google-cloud-storage/default.nix +++ b/pkgs/development/python-modules/google-cloud-storage/default.nix @@ -1,7 +1,7 @@ { lib, buildPythonPackage, - fetchPypi, + fetchFromGitHub, google-auth, google-cloud-core, google-cloud-iam, @@ -21,12 +21,11 @@ buildPythonPackage rec { version = "3.2.0"; pyproject = true; - disabled = pythonOlder "3.7"; - - src = fetchPypi { - pname = "google_cloud_storage"; - inherit version; - hash = "sha256-3syoQwdgNvRWMxmMEl0YYf+/R+v1wOO5jcubLbFViWw="; + src = fetchFromGitHub { + owner = "googleapis"; + repo = "python-storage"; + tag = "v${version}"; + hash = "sha256-05jPtpsEQYqReDaeLj/Vzkz761jZfLQXC20WjTIPVc8="; }; pythonRelaxDeps = [ "google-auth" ]; @@ -52,6 +51,11 @@ buildPythonPackage rec { pytestCheckHook ]; + enabledTestPaths = [ + "tests/unit/" + "tests/system/" + ]; + disabledTests = [ # Disable tests which require credentials and network access "create" @@ -72,6 +76,7 @@ buildPythonPackage rec { ]; disabledTestPaths = [ + "samples/" "tests/unit/test_bucket.py" "tests/system/test_blob.py" "tests/system/test_bucket.py" @@ -90,11 +95,11 @@ buildPythonPackage rec { pythonImportsCheck = [ "google.cloud.storage" ]; - meta = with lib; { + meta = { description = "Google Cloud Storage API client library"; homepage = "https://github.com/googleapis/python-storage"; changelog = "https://github.com/googleapis/python-storage/blob/v${version}/CHANGELOG.md"; - license = licenses.asl20; - maintainers = [ ]; + license = lib.licenses.asl20; + maintainers = with lib.maintainers; [ ]; }; } From 397c8fec7bfe00705a915c31f1a809f658945c23 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Sat, 16 Aug 2025 09:17:27 -0700 Subject: [PATCH 2/3] python3Packages.google-cloud-storage: add sarahec as maintainer --- .../development/python-modules/google-cloud-storage/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/google-cloud-storage/default.nix b/pkgs/development/python-modules/google-cloud-storage/default.nix index 314d513b0b59..c9460a6dbdd2 100644 --- a/pkgs/development/python-modules/google-cloud-storage/default.nix +++ b/pkgs/development/python-modules/google-cloud-storage/default.nix @@ -100,6 +100,6 @@ buildPythonPackage rec { homepage = "https://github.com/googleapis/python-storage"; changelog = "https://github.com/googleapis/python-storage/blob/v${version}/CHANGELOG.md"; license = lib.licenses.asl20; - maintainers = with lib.maintainers; [ ]; + maintainers = with lib.maintainers; [ sarahec ]; }; } From 87598dd2df79dd7178461568739a7f64f52a3af1 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Sat, 16 Aug 2025 09:18:23 -0700 Subject: [PATCH 3/3] python3Packages.google-cloud-storage: 3.2.0 -> 3.3.0 changelog: https://github.com/googleapis/python-storage/releases/tag/v3.2.0 diff: https://github.com/googleapis/python-storage/compare/v3.2.0...v3.3.0 --- .../python-modules/google-cloud-storage/default.nix | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/google-cloud-storage/default.nix b/pkgs/development/python-modules/google-cloud-storage/default.nix index c9460a6dbdd2..f0eed472c57b 100644 --- a/pkgs/development/python-modules/google-cloud-storage/default.nix +++ b/pkgs/development/python-modules/google-cloud-storage/default.nix @@ -18,14 +18,14 @@ buildPythonPackage rec { pname = "google-cloud-storage"; - version = "3.2.0"; + version = "3.3.0"; pyproject = true; src = fetchFromGitHub { owner = "googleapis"; repo = "python-storage"; tag = "v${version}"; - hash = "sha256-05jPtpsEQYqReDaeLj/Vzkz761jZfLQXC20WjTIPVc8="; + hash = "sha256-I0wC/BV8fJr3JW1nyq2TPJZlZaT4+h2lJBdGTttSzRo="; }; pythonRelaxDeps = [ "google-auth" ]; @@ -76,7 +76,6 @@ buildPythonPackage rec { ]; disabledTestPaths = [ - "samples/" "tests/unit/test_bucket.py" "tests/system/test_blob.py" "tests/system/test_bucket.py"