From bfd0d13dc984b8f6fcedccd2c26f1a2c7b5e3261 Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Sat, 11 Oct 2025 18:07:26 -0700 Subject: [PATCH] rocmPackages.hipblaslt: remove comment patch no longer needed now we unlink .s / .o files as soon as possible --- .../rocm-modules/6/hipblaslt/default.nix | 3 -- .../6/hipblaslt/reduce-comment-spam.patch | 47 ------------------- 2 files changed, 50 deletions(-) delete mode 100644 pkgs/development/rocm-modules/6/hipblaslt/reduce-comment-spam.patch diff --git a/pkgs/development/rocm-modules/6/hipblaslt/default.nix b/pkgs/development/rocm-modules/6/hipblaslt/default.nix index c5f69d37906e..fe395d874d15 100644 --- a/pkgs/development/rocm-modules/6/hipblaslt/default.nix +++ b/pkgs/development/rocm-modules/6/hipblaslt/default.nix @@ -113,9 +113,6 @@ stdenv.mkDerivation (finalAttrs: { # Support loading zstd compressed .dat files, required to keep output under # hydra size limit ./messagepack-compression-support.patch - # excessive comments are written to temporary asm files in build dir - # TODO: report upstream, find a better solution - ./reduce-comment-spam.patch # [hipblaslt] Refactor Parallel.py to drop joblib, massively reduce peak disk space usage # https://github.com/ROCm/rocm-libraries/pull/2073 ./TensileCreateLibrary-refactor.patch diff --git a/pkgs/development/rocm-modules/6/hipblaslt/reduce-comment-spam.patch b/pkgs/development/rocm-modules/6/hipblaslt/reduce-comment-spam.patch deleted file mode 100644 index 32969c517781..000000000000 --- a/pkgs/development/rocm-modules/6/hipblaslt/reduce-comment-spam.patch +++ /dev/null @@ -1,47 +0,0 @@ -diff --git a/projects/hipblaslt/tensilelite/rocisa/rocisa/include/format.hpp b/projects/hipblaslt/tensilelite/rocisa/rocisa/include/format.hpp -index b7dcb6f59a..b0625ba769 100644 ---- a/tensilelite/rocisa/rocisa/include/format.hpp -+++ b/tensilelite/rocisa/rocisa/include/format.hpp -@@ -8,11 +8,13 @@ namespace rocisa - // Text format functions - inline std::string slash(const std::string& comment) - { -+ return ""; - return "// " + comment + "\n"; - } - - inline std::string slash50(const std::string& comment) - { -+ return ""; - std::ostringstream oss; - oss << std::setw(50) << "" - << " // " << comment << "\n"; -@@ -21,16 +23,19 @@ namespace rocisa - - inline std::string block(const std::string& comment) - { -+ return ""; - return "/* " + comment + " */\n"; - } - - inline std::string blockNewLine(const std::string& comment) - { -+ return ""; - return "\n/* " + comment + " */\n"; - } - - inline std::string block3Line(const std::string& comment) - { -+ return ""; - std::ostringstream oss; - oss << "\n/******************************************/\n"; - std::istringstream iss(comment); -@@ -52,7 +57,7 @@ namespace rocisa - { - formattedStr = "\"" + formattedStr + "\\n\\t\""; - } -- if(!comment.empty()) -+ if(false) - { - std::string buffer = formattedStr - + std::string(std::max(0, 50 - int(formattedStr.length())), ' ')