From bfc7aaa8af566318ad5b0ef35fc8652fecc2945e Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Wed, 26 Apr 2023 14:03:11 +0000 Subject: [PATCH] wrapCCWith: disable pic when building for Windows According to , all code is position-independent on Windows. Some compilers apparently warn for -fPIC on Windows, and clang errors: > clang-15: error: unsupported option '-fPIC' for target 'x86_64-pc-windows-msvc' I'm guessing the check was hostPlatform instead of targetPlatform by mistake. --- pkgs/build-support/cc-wrapper/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/build-support/cc-wrapper/default.nix b/pkgs/build-support/cc-wrapper/default.nix index adab6f239a61..bc9c199f778d 100644 --- a/pkgs/build-support/cc-wrapper/default.nix +++ b/pkgs/build-support/cc-wrapper/default.nix @@ -518,7 +518,7 @@ stdenv.mkDerivation { '' # TODO: categorize these and figure out a better place for them - + optionalString hostPlatform.isCygwin '' + + optionalString targetPlatform.isWindows '' hardening_unsupported_flags+=" pic" '' + optionalString targetPlatform.isMinGW '' hardening_unsupported_flags+=" stackprotector fortify"