From 9bfb4a53b2713d07b3829fe914637b4bacf92c69 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= <joerg@thalheim.io>
Date: Thu, 5 Feb 2026 14:53:51 +0100
Subject: [PATCH] postgresqlPackages.cstore_fdw: remove broken extension

cstore_fdw has been marked broken since NixOS 24.05 for PostgreSQL 14+
and remains unfixed. The extension is incompatible with modern
PostgreSQL versions.

Per RFC 180, packages broken for a full release cycle are subject
to removal.

https://github.com/NixOS/rfcs/pull/180
---
 pkgs/servers/sql/postgresql/ext.nix           |  1 +
 .../servers/sql/postgresql/ext/cstore_fdw.nix | 31 -------------------
 2 files changed, 1 insertion(+), 31 deletions(-)
 delete mode 100644 pkgs/servers/sql/postgresql/ext/cstore_fdw.nix

diff --git a/pkgs/servers/sql/postgresql/ext.nix b/pkgs/servers/sql/postgresql/ext.nix
index 1be386255117..4593540d2e71 100644
--- a/pkgs/servers/sql/postgresql/ext.nix
+++ b/pkgs/servers/sql/postgresql/ext.nix
@@ -21,5 +21,6 @@ in
   pltcl = throw "PostgreSQL extension `pltcl` is not available, because `postgresql` was built without Tcl support. Override with `tclSupport = true` to enable the extension.";
 }
 // lib.optionalAttrs config.allowAliases {
+  cstore_fdw = throw "PostgreSQL extension `cstore_fdw` has been removed due to being broken for more than a year; see RFC 180"; # Added 2026-02-05
   pg_embedding = throw "PostgreSQL extension `pg_embedding` has been removed since the project has been abandoned. Upstream's recommendation is to use pgvector instead (https://neon.tech/docs/extensions/pg_embedding#migrate-from-pg_embedding-to-pgvector)";
 }
diff --git a/pkgs/servers/sql/postgresql/ext/cstore_fdw.nix b/pkgs/servers/sql/postgresql/ext/cstore_fdw.nix
deleted file mode 100644
index 918f446081de..000000000000
--- a/pkgs/servers/sql/postgresql/ext/cstore_fdw.nix
+++ /dev/null
@@ -1,31 +0,0 @@
-{
-  fetchFromGitHub,
-  lib,
-  postgresql,
-  postgresqlBuildExtension,
-  protobufc,
-}:
-
-postgresqlBuildExtension {
-  pname = "cstore_fdw";
-  version = "1.7.0-unstable-2021-03-08";
-
-  buildInputs = [ protobufc ];
-  nativeBuildInputs = [ protobufc ];
-
-  src = fetchFromGitHub {
-    owner = "citusdata";
-    repo = "cstore_fdw";
-    rev = "90e22b62fbee6852529104fdd463f532cf7a3311";
-    hash = "sha256-02wcCqs8A5ZOZX080fgcNJTQrYQctnlwnA8+YPaRTZc=";
-  };
-
-  meta = {
-    broken = lib.versionAtLeast postgresql.version "14";
-    description = "Columnar storage for PostgreSQL";
-    homepage = "https://github.com/citusdata/cstore_fdw";
-    maintainers = with lib.maintainers; [ thoughtpolice ];
-    platforms = postgresql.meta.platforms;
-    license = lib.licenses.asl20;
-  };
-}