From 8826b550a0d519c9adfd5d024ec8557170d34dc5 Mon Sep 17 00:00:00 2001 From: Mario Rodas Date: Thu, 30 Mar 2023 04:20:00 +0000 Subject: [PATCH 1/2] ruby: update default version to `ruby_3_1` --- pkgs/development/interpreters/ruby/default.nix | 2 +- pkgs/top-level/all-packages.nix | 12 +++--------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/pkgs/development/interpreters/ruby/default.nix b/pkgs/development/interpreters/ruby/default.nix index 99a77bfedc7c..702780b999b3 100644 --- a/pkgs/development/interpreters/ruby/default.nix +++ b/pkgs/development/interpreters/ruby/default.nix @@ -51,7 +51,7 @@ let , buildEnv, bundler, bundix , libiconv, libobjc, libunwind, Foundation , makeBinaryWrapper, buildRubyGem, defaultGemConfig - , baseRuby ? buildPackages.ruby_3_1.override { + , baseRuby ? buildPackages.ruby.override { docSupport = false; rubygemsSupport = false; } diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 73b601bbb8e9..ec246059a6cd 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -5864,13 +5864,7 @@ with pkgs; enableExtraPlugins = true; }; - asciidoctor = callPackage ../tools/typesetting/asciidoctor { - bundlerApp = bundlerApp.override { - # asciidoc supports both ruby 2 and 3, - # but we don't want to be stuck on it: - ruby = ruby_3_1; - }; - }; + asciidoctor = callPackage ../tools/typesetting/asciidoctor { }; asciidoctor-with-extensions = callPackage ../tools/typesetting/asciidoctor-with-extensions { }; @@ -17012,8 +17006,8 @@ with pkgs; ruby_3_1 ruby_3_2; - ruby = ruby_2_7; - rubyPackages = rubyPackages_2_7; + ruby = ruby_3_1; + rubyPackages = rubyPackages_3_1; rubyPackages_2_7 = recurseIntoAttrs ruby_2_7.gems; rubyPackages_3_0 = recurseIntoAttrs ruby_3_0.gems; From a5aa37989156c23be3bed2c8da33f28427845caa Mon Sep 17 00:00:00 2001 From: Mario Rodas Date: Sat, 15 Apr 2023 04:20:00 +0000 Subject: [PATCH 2/2] gitlab: use Ruby 2.7 GitLab doesn't support Ruby 3 yet https://gitlab.com/groups/gitlab-org/-/epics/5149 --- pkgs/applications/version-management/gitlab/default.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/version-management/gitlab/default.nix b/pkgs/applications/version-management/gitlab/default.nix index c83478f05a91..8e20cc8a7944 100644 --- a/pkgs/applications/version-management/gitlab/default.nix +++ b/pkgs/applications/version-management/gitlab/default.nix @@ -1,5 +1,5 @@ { stdenv, lib, fetchurl, fetchpatch, fetchFromGitLab, bundlerEnv -, ruby, tzdata, git, nettools, nixosTests, nodejs, openssl +, ruby_2_7, tzdata, git, nettools, nixosTests, nodejs, openssl , gitlabEnterprise ? false, callPackage, yarn , fixup_yarn_lock, replace, file, cacert, fetchYarnDeps, makeWrapper, pkg-config }: @@ -17,7 +17,8 @@ let rubyEnv = bundlerEnv rec { name = "gitlab-env-${version}"; - inherit ruby; + # GitLab doesn't support Ruby 3 https://gitlab.com/groups/gitlab-org/-/epics/5149 + ruby = ruby_2_7; gemdir = ./rubyEnv; gemset = let x = import (gemdir + "/gemset.nix") src;