From bec48839d33e90fe0e969b2c8a46c4f11d122475 Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Wed, 31 Jul 2024 13:35:38 -0500 Subject: [PATCH] revive: re-enable tests It seems this was originally added in https://github.com/NixOS/nixpkgs/pull/176812 and @r-ryantm has misleadingly been bumping the version in the comment, too. The tests run fine for v1.3.9, at least. --- pkgs/development/tools/revive/default.nix | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/pkgs/development/tools/revive/default.nix b/pkgs/development/tools/revive/default.nix index a22fc7101e2e..1c181c0efbe0 100644 --- a/pkgs/development/tools/revive/default.nix +++ b/pkgs/development/tools/revive/default.nix @@ -42,17 +42,6 @@ buildGoModule rec { --prefix PATH : ${lib.makeBinPath [ go ]} ''; - # The following tests fail when built by nix: - # - # $ nix log /nix/store/build-revive.1.3.9.drv | grep FAIL - # - # --- FAIL: TestAll (0.01s) - # --- FAIL: TestTimeEqual (0.00s) - # --- FAIL: TestTimeNaming (0.00s) - # --- FAIL: TestUnhandledError (0.00s) - # --- FAIL: TestUnhandledErrorWithBlacklist (0.00s) - doCheck = false; - meta = with lib; { description = "Fast, configurable, extensible, flexible, and beautiful linter for Go"; mainProgram = "revive";