From c89c90dfa137316f3cf662783b4795d8b9897237 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Fri, 18 Jul 2025 09:23:17 +0200 Subject: [PATCH] .github/PULL_REQUEST_TEMPLATE: remove +1 footer The footer has the following problems: - It's not consistently added in all PRs, for example backports or those where the template is not used. Inconsistency in a voting skews the results. - It's arguably not effective, because people use reactions naturally to interact with PRs anyway. As long as there are multiple different reaction types, what does it mean that one PR has 20 :+1:, but another has 22 :tada:? The latter won't show up in the ranking for :+1:, so at the minimum confusing. Same for :heart:. - It's not useful to determine priority as in "higher number of votes should be merged". A PR's quality should be determined independently of votes - when it's good, it will be merged. The currently most upvoted PR has serious issues, so this invites drive-by questions like "Why isn't this merged, given the number of upvotes?". --- .github/PULL_REQUEST_TEMPLATE.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 85561029c86a..45a55eb45dce 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -38,10 +38,3 @@ For new packages please briefly describe the package or provide a link to its ho [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test - ---- - -Add a :+1: [reaction] to [pull requests you find important]. - -[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ -[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc