From bd8743e62c2e3158ca1b618d92e7f6b695baa3fa Mon Sep 17 00:00:00 2001 From: Andrew Marshall Date: Thu, 3 Apr 2025 08:37:24 -0400 Subject: [PATCH] git-cinnabar: minor cleanup - Prefer `tag` over `rev` - `checkNoDefaultFeatures` defaults to value of `buildNoDefaultFeatures`, so remove explicit setting --- pkgs/by-name/gi/git-cinnabar/package.nix | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/by-name/gi/git-cinnabar/package.nix b/pkgs/by-name/gi/git-cinnabar/package.nix index 73619ecf6df6..af1b84ca6a4a 100644 --- a/pkgs/by-name/gi/git-cinnabar/package.nix +++ b/pkgs/by-name/gi/git-cinnabar/package.nix @@ -18,7 +18,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "glandium"; repo = "git-cinnabar"; - rev = finalAttrs.version; + tag = finalAttrs.version; hash = "sha256-RUrklp2hobHKnBZKVvxMGquNSZBG/rVWaD/m+7AWqHo="; fetchSubmodules = true; }; @@ -47,7 +47,6 @@ stdenv.mkDerivation (finalAttrs: { # Disable automated version-check buildNoDefaultFeatures = true; - checkNoDefaultFeatures = true; installPhase = '' runHook preInstall