From bd02bf1ea341f223fe26107ffda41a4abf0b66fd Mon Sep 17 00:00:00 2001 From: Artturin Date: Wed, 25 Oct 2023 03:15:00 +0300 Subject: [PATCH] qt5: remove `with self;` The `self` does not contain spliced packages, callPackage works properly. --- pkgs/development/libraries/qt-5/5.15/default.nix | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkgs/development/libraries/qt-5/5.15/default.nix b/pkgs/development/libraries/qt-5/5.15/default.nix index f5e29bc8a54d..8a859af37e9d 100644 --- a/pkgs/development/libraries/qt-5/5.15/default.nix +++ b/pkgs/development/libraries/qt-5/5.15/default.nix @@ -201,7 +201,7 @@ let qttools = [ ./qttools.patch ]; }; - addPackages = self: with self; + addPackages = self: let qtModule = callPackage ../qtModule.nix { inherit patches; @@ -218,7 +218,7 @@ let mkDerivationWith = callPackage ../mkDerivation.nix { }; - mkDerivation = mkDerivationWith stdenv.mkDerivation; + mkDerivation = callPackage ({ mkDerivationWith }: mkDerivationWith stdenv.mkDerivation) { }; qtbase = callPackage ../modules/qtbase.nix { inherit (srcs.qtbase) src version; @@ -300,7 +300,9 @@ let qtxmlpatterns = callPackage ../modules/qtxmlpatterns.nix {}; env = callPackage ../qt-env.nix {}; - full = env "qt-full-${qtbase.version}" ([ + full = callPackage ({ env, qtbase }: env "qt-full-${qtbase.version}") { } + # `with self` is ok to use here because having these spliced is unnecessary + (with self; [ qt3d qtcharts qtconnectivity qtdeclarative qtdoc qtgraphicaleffects qtimageformats qtlocation qtmultimedia qtquickcontrols qtquickcontrols2 qtscript qtsensors qtserialport qtsvg qttools qttranslations