From 7491fdf61f3b294f396f6cfccac1d12ce5b600ed Mon Sep 17 00:00:00 2001 From: William Brockhus Date: Thu, 8 May 2025 15:59:30 +1000 Subject: [PATCH 1/2] kid3: enable build flag WITH_MP4V2 Support for editing m4b chapters was added to kid3 with v3.9.2, but this feature requires the Mp4v2Metadata plugin, which is only built when WITH_MP4V2=ON is added to the build flags. https://invent.kde.org/multimedia/kid3/-/releases/v3.9.2 https://docs.kde.org/trunk5/en/kid3/kid3/commands.html#mp4-chapters https://github.com/KDE/kid3/blob/master/INSTALL --- pkgs/by-name/ki/kid3/package.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/by-name/ki/kid3/package.nix b/pkgs/by-name/ki/kid3/package.nix index ca7416a60167..16dd16b8af28 100644 --- a/pkgs/by-name/ki/kid3/package.nix +++ b/pkgs/by-name/ki/kid3/package.nix @@ -88,7 +88,10 @@ stdenv.mkDerivation (finalAttrs: { ] ); - cmakeFlags = [ (lib.cmakeFeature "WITH_APPS" apps) ]; + cmakeFlags = [ + (lib.cmakeFeature "WITH_APPS" apps) + (lib.cmakeFeature "WITH_MP4V2" "ON") + ]; env = { DOCBOOKDIR = "${docbook_xsl}/xml/xsl/docbook/"; From 6181ed5dec602c83f3db78be84974896c850a4ce Mon Sep 17 00:00:00 2001 From: William Brockhus Date: Mon, 26 May 2025 09:33:46 +1000 Subject: [PATCH 2/2] kid3: use cmakeBool for WITH_MP4V2 build flag instead of string Co-authored-by: Peder Bergebakken Sundt --- pkgs/by-name/ki/kid3/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/ki/kid3/package.nix b/pkgs/by-name/ki/kid3/package.nix index 16dd16b8af28..f19d9f75b03d 100644 --- a/pkgs/by-name/ki/kid3/package.nix +++ b/pkgs/by-name/ki/kid3/package.nix @@ -90,7 +90,7 @@ stdenv.mkDerivation (finalAttrs: { cmakeFlags = [ (lib.cmakeFeature "WITH_APPS" apps) - (lib.cmakeFeature "WITH_MP4V2" "ON") + (lib.cmakeBool "WITH_MP4V2" true) ]; env = {