From f2930d67f551ada20cca6c690989d0bae3233ea2 Mon Sep 17 00:00:00 2001 From: Sigmanificient Date: Fri, 16 Jan 2026 03:14:21 +0100 Subject: [PATCH] buck: drop --- .../tools/build-managers/buck/default.nix | 69 ------------------- .../tools/build-managers/buck/pex-mtime.patch | 13 ---- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 4 -- 4 files changed, 1 insertion(+), 86 deletions(-) delete mode 100644 pkgs/development/tools/build-managers/buck/default.nix delete mode 100644 pkgs/development/tools/build-managers/buck/pex-mtime.patch diff --git a/pkgs/development/tools/build-managers/buck/default.nix b/pkgs/development/tools/build-managers/buck/default.nix deleted file mode 100644 index a5010236588c..000000000000 --- a/pkgs/development/tools/build-managers/buck/default.nix +++ /dev/null @@ -1,69 +0,0 @@ -{ - lib, - stdenv, - fetchFromGitHub, - jdk8, - ant, - python3, - watchman, - bash, - makeWrapper, -}: - -stdenv.mkDerivation rec { - pname = "buck"; - version = "2022.05.05.01"; - - src = fetchFromGitHub { - owner = "facebook"; - repo = pname; - rev = "v${version}"; - sha256 = "15v4sk1l43pgd5jxr5lxnh0ks6vb3xk5253n66s7vvsnph48j14q"; - }; - - patches = [ ./pex-mtime.patch ]; - - postPatch = '' - grep -l -r '/bin/bash' --null | xargs -0 sed -i -e "s!/bin/bash!${bash}/bin/bash!g" - ''; - - nativeBuildInputs = [ - makeWrapper - python3 - jdk8 - ant - watchman - ]; - - buildPhase = '' - # Set correct version, see https://github.com/facebook/buck/issues/2607 - echo v${version} > .buckrelease - - ant - - PYTHONDONTWRITEBYTECODE=true ./bin/buck build -c buck.release_version=${version} buck - ''; - - installPhase = '' - install -D -m755 buck-out/gen/*/programs/buck.pex $out/bin/buck - wrapProgram $out/bin/buck \ - --prefix PATH : "${ - lib.makeBinPath [ - jdk8 - watchman - python3 - ] - }" - ''; - - meta = { - homepage = "https://buck.build/"; - description = "High-performance build tool"; - mainProgram = "buck"; - maintainers = [ lib.maintainers.jgertm ]; - license = lib.licenses.asl20; - platforms = lib.platforms.all; - # https://github.com/facebook/buck/issues/2666 - broken = stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64; - }; -} diff --git a/pkgs/development/tools/build-managers/buck/pex-mtime.patch b/pkgs/development/tools/build-managers/buck/pex-mtime.patch deleted file mode 100644 index b8726e64a604..000000000000 --- a/pkgs/development/tools/build-managers/buck/pex-mtime.patch +++ /dev/null @@ -1,13 +0,0 @@ -diff --git a/third-party/py/pex/pex/common.py b/third-party/py/pex/pex/common.py -index 76459ce23..eff411b20 100644 ---- a/third-party/py/pex/pex/common.py -+++ b/third-party/py/pex/pex/common.py -@@ -328,4 +328,7 @@ class Chroot(object): - def zip(self, filename, mode='wb'): - with contextlib.closing(zipfile.ZipFile(filename, mode)) as zf: - for f in sorted(self.files()): -- zf.write(os.path.join(self.chroot, f), arcname=f, compress_type=zipfile.ZIP_DEFLATED) -+ path = os.path.join(self.chroot, f) -+ instant = 615532801 -+ os.utime(path, (instant, instant)) -+ zf.write(path, arcname=f, compress_type=zipfile.ZIP_DEFLATED) diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index c264d6bee66a..6f5978e12d51 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -382,6 +382,7 @@ mapAliases { breath-theme = throw "'breath-theme' has been removed, as it is only compatible with Plasma 5, which is EOL"; # Added 2025-08-20 brogue = warnAlias "Use 'brogue-ce' instead of 'brogue' for updated releases" brogue-ce; # Added 2025-10-04 btanks = throw "'btanks' has been removed as it's been unmaintained since 2010 and fails to build"; # Added 2025-11-29 + buck = throw "'buck' has been removed has it was deprecated and archived upstream. Consider moving to buck2"; # Added 2026-01-16 buildBowerComponents = throw "buildBowerComponents has been removed as bower was removed. It is recommended to migrate to yarn."; # Added 2025-09-17 buildGo123Module = throw "Go 1.23 is end-of-life, and 'buildGo123Module' has been removed. Please use a newer builder version."; # Added 2025-08-13 buildPlatform = warnAlias "'buildPlatform' has been renamed to/replaced by 'stdenv.buildPlatform'" stdenv.buildPlatform; # Converted to warning 2025-10-28 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 1d744ba764a4..4c52df200c98 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -5943,10 +5943,6 @@ with pkgs; black-macchiato = with python3Packages; toPythonApplication black-macchiato; - buck = callPackage ../development/tools/build-managers/buck { - python3 = python311; - }; - build2 = callPackage ../development/tools/build-managers/build2 { # Break cycle by using self-contained toolchain for bootstrapping build2 = buildPackages.callPackage ../development/tools/build-managers/build2/bootstrap.nix { };