From b8cf634aa1f64ff828a2fe5c729ddce490deab28 Mon Sep 17 00:00:00 2001 From: David McFarland Date: Tue, 30 Sep 2025 19:05:25 -0300 Subject: [PATCH] Revert "treewide: undo changes causing rebuilds" This reverts commit e098bea39d9d1c15214aa026bb50893a7459b2b0. --- .../compilers/gcc/patches/default.nix | 2 +- pkgs/stdenv/generic/make-derivation.nix | 21 +++++++------------ 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/pkgs/development/compilers/gcc/patches/default.nix b/pkgs/development/compilers/gcc/patches/default.nix index 2c0fa1b40852..619b3a922f31 100644 --- a/pkgs/development/compilers/gcc/patches/default.nix +++ b/pkgs/development/compilers/gcc/patches/default.nix @@ -224,7 +224,7 @@ in .${majorVersion} or [ ] ) -++ optional targetPlatform.isCygwin (fetchpatch { +++ optional (targetPlatform.isWindows || targetPlatform.isCygwin) (fetchpatch { name = "libstdc-fix-compilation-in-freestanding-win32.patch"; url = "https://inbox.sourceware.org/gcc-patches/20250922182808.2599390-2-corngood@gmail.com/raw"; hash = "sha256-+EYW9lG8CviVX7RyNHp+iX+8BRHUjt5b07k940khbbY="; diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix index bbd4c0a14f65..8c291ccf4920 100644 --- a/pkgs/stdenv/generic/make-derivation.nix +++ b/pkgs/stdenv/generic/make-derivation.nix @@ -706,19 +706,14 @@ let __propagatedImpureHostDeps = computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps; } ) - // optionalAttrs (isWindows || isCygwin) ( - let - dlls = - allowedImpureDLLs - ++ lib.optionals isCygwin [ - "KERNEL32.dll" - "cygwin1.dll" - ]; - in - { - allowedImpureDLLs = if dlls != [ ] then dlls else null; - } - ) + // optionalAttrs (isWindows || isCygwin) { + allowedImpureDLLs = + allowedImpureDLLs + ++ lib.optionals isCygwin [ + "KERNEL32.dll" + "cygwin1.dll" + ]; + } // ( if !__structuredAttrs then makeOutputChecks attrs