From b415ac4a9ebe8381fd7cd7348c81fffed4451e66 Mon Sep 17 00:00:00 2001 From: Alex James Date: Tue, 8 Jul 2025 00:19:28 -0500 Subject: [PATCH] samba: readd liburing to `buildInputs` on Linux ce5ebeb90c20 ("samba4: fixup build on linux") removed liburing from buildInputs on Linux to work around a compilation error [1]. A fix for the compilation error was included in liburing 2.11 [2]. Readd the liburing dependency to restore support for vfs_io_uring. [1]: https://hydra.nixos.org/build/298833701/nixlog/3/tail [2]: https://github.com/axboe/liburing/commit/1b99ce4856f64c1056b3c394062cba35bd045718 --- pkgs/servers/samba/4.x.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/servers/samba/4.x.nix b/pkgs/servers/samba/4.x.nix index cccb18aa8941..91f1e31d03d6 100644 --- a/pkgs/servers/samba/4.x.nix +++ b/pkgs/servers/samba/4.x.nix @@ -167,7 +167,7 @@ stdenv.mkDerivation (finalAttrs: { libbsd ] ++ optionals stdenv.hostPlatform.isLinux [ - #liburing # FIXME: better solution + liburing systemd ] ++ optionals stdenv.hostPlatform.isDarwin [ libiconv ]