From 21806777f2c18104f043bb229f29adf5358983f2 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Thu, 29 May 2025 14:06:13 -0700 Subject: [PATCH 1/2] python3Packages.google-cloud-spanner: add optional dependencies for tracing --- .../google-cloud-spanner/default.nix | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/pkgs/development/python-modules/google-cloud-spanner/default.nix b/pkgs/development/python-modules/google-cloud-spanner/default.nix index 66b18afb7c96..f1e6c1129008 100644 --- a/pkgs/development/python-modules/google-cloud-spanner/default.nix +++ b/pkgs/development/python-modules/google-cloud-spanner/default.nix @@ -19,14 +19,14 @@ # optional dependencies libcst, - - # testing - google-cloud-monitoring, - mmh3, - mock, opentelemetry-api, opentelemetry-sdk, opentelemetry-semantic-conventions, + google-cloud-monitoring, + mmh3, + + # testing + mock, pytest-asyncio, pytestCheckHook, }: @@ -54,10 +54,18 @@ buildPythonPackage rec { proto-plus protobuf sqlparse - ] ++ google-api-core.optional-dependencies.grpc; + ]; optional-dependencies = { libcst = [ libcst ]; + tracing = [ + opentelemetry-api + opentelemetry-sdk + opentelemetry-semantic-conventions + # opentelemetry-resourcedetector-gcp # Not available in nixpkgs + google-cloud-monitoring + mmh3 + ]; }; nativeCheckInputs = [ @@ -70,7 +78,7 @@ buildPythonPackage rec { opentelemetry-semantic-conventions pytest-asyncio pytestCheckHook - ]; + ] ++ lib.flatten (lib.attrValues optional-dependencies); preCheck = '' # prevent google directory from shadowing google imports @@ -117,7 +125,7 @@ buildPythonPackage rec { meta = { description = "Cloud Spanner API client library"; homepage = "https://github.com/googleapis/python-spanner"; - changelog = "https://github.com/googleapis/python-spanner/blob/v${version}/CHANGELOG.md"; + changelog = "https://github.com/googleapis/python-spanner/blob/${src.tag}/CHANGELOG.md"; license = lib.licenses.asl20; maintainers = [ lib.maintainers.sarahec ]; }; From 6c52e60f205ed8ebfc636bcaed8cf4fedcae45d6 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Thu, 29 May 2025 14:13:06 -0700 Subject: [PATCH 2/2] python3Packages.google-cloud-spanner: 3.54.0 -> 3.55.0 changelog: https://github.com/googleapis/python-spanner/releases/tag/v3.55.0 diff: https://github.com/googleapis/python-spanner/compare/v3.54.0...v3.55.0 --- .../python-modules/google-cloud-spanner/default.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkgs/development/python-modules/google-cloud-spanner/default.nix b/pkgs/development/python-modules/google-cloud-spanner/default.nix index f1e6c1129008..a580a84ded06 100644 --- a/pkgs/development/python-modules/google-cloud-spanner/default.nix +++ b/pkgs/development/python-modules/google-cloud-spanner/default.nix @@ -33,14 +33,14 @@ buildPythonPackage rec { pname = "google-cloud-spanner"; - version = "3.54.0"; + version = "3.55.0"; pyproject = true; src = fetchFromGitHub { owner = "googleapis"; repo = "python-spanner"; tag = "v${version}"; - hash = "sha256-uJKUgY7fV+AK/2HQyjQRFypcL+mPZ/M5ZtAU+f73ezM="; + hash = "sha256-0+mTBqgy8SaHjoYhQjCaypipVsJTrN2DdhcfPY3PxSc="; }; build-system = [ setuptools ]; @@ -92,6 +92,8 @@ buildPythonPackage rec { "test_list_instance" # can't import mmh3 "test_generate_client_hash" + # Flaky, compares to execution time + "test_snapshot_read_concurrent" ]; disabledTestPaths = [